[Sync] Support commit only types.

components/sync/user_events/user_event_sync_bridge.cc

 // Copyright 2017 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "components/sync/user_events/user_event_sync_bridge.h"
 
 #include <utility>
 
 #include "base/big_endian.h"
 #include "base/bind.h"
@@ skipping 66 matching lines @@
 base::Optional<ModelError> UserEventSyncBridge::MergeSyncData(
     std::unique_ptr<MetadataChangeList> metadata_change_list,
     EntityDataMap entity_data_map) {
   NOTREACHED();
   return {};
 }
 
 base::Optional<ModelError> UserEventSyncBridge::ApplySyncChanges(
     std::unique_ptr<MetadataChangeList> metadata_change_list,
     EntityChangeList entity_changes) {
-  NOTREACHED();
+  std::unique_ptr<WriteBatch> batch = store_->CreateWriteBatch();
+  for (EntityChange& change : entity_changes) {
+    DCHECK_EQ(EntityChange::ACTION_DELETE, change.type());

[Patrick Noland, 2017/06/01 21:34:40]

Are you sure you just want to DCHECK this condition? Maybe it would be better to
just ignore non-deletes? Imagine you try to delete an entity when the change
type was ADD and fail to do so, are you really in an error state?

[skym, 2017/06/01 22:43:20]

The processor should never send us any other action. We don't have any handling
for any other action. You're right that we could ignore it.

Even if we change our minds about USER_EVENTS in the future and start sending
remote changes down to chrome clients, these old clients aren't going to see
that data. We don't currently have progress markers, we don't currently include
USER_EVENTS in GetUpdates calls. I think we're safe to make changes without
locking ourselves in here with the DCHECK.

It's difficult to reason about what the correct handling of an ADD should be,
because it shouldn't happen. Deleting events is low impact anyways.

+    batch->DeleteData(change.storage_key());
+  }
+  batch->TransferMetadataChanges(std::move(metadata_change_list));
+  store_->CommitWriteBatch(
+      std::move(batch),
+      base::Bind(&UserEventSyncBridge::OnCommit, base::AsWeakPtr(this)));
   return {};
 }
 
 void UserEventSyncBridge::GetData(StorageKeyList storage_keys,
                                   DataCallback callback) {
   store_->ReadData(storage_keys, base::Bind(&UserEventSyncBridge::OnReadData,
                                             base::AsWeakPtr(this), callback));
 }
 
 void UserEventSyncBridge::GetAllData(DataCallback callback) {
@@ skipping 107 matching lines @@
   std::unique_ptr<WriteBatch> batch = store_->CreateWriteBatch();
   for (const Record& r : *data_records) {
     batch->DeleteData(r.id);
   }
   store_->CommitWriteBatch(
       std::move(batch),
       base::Bind(&UserEventSyncBridge::OnCommit, base::AsWeakPtr(this)));
 }
 
 }  // namespace syncer