Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(322)

Unified Diff: tools/testing/dart/options.dart

Issue 2916123002: Remove temp code to ignore "--failure-summary". (Closed)
Patch Set: Merge branch 'master' into failure-summary-flag Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tools/bots/run_android_tests.sh ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/testing/dart/options.dart
diff --git a/tools/testing/dart/options.dart b/tools/testing/dart/options.dart
index 9b76138ea72e92f3e81b6af83daa617c4d390e12..18459a0fd008bef16deed78b01e3d2297eb477b9 100644
--- a/tools/testing/dart/options.dart
+++ b/tools/testing/dart/options.dart
@@ -330,14 +330,6 @@ compiler.''')
/// encountering the first non-option string, the rest of the arguments are
/// stored in the returned Map under the 'rest' key.
List<Configuration> parse(List<String> arguments) {
- // TODO(rnystrom): The builders on the buildbots still pass this even
- // though it does nothing. Until those can be fixed, silently ignore the
- // option. Remove this once the buildbot scripts are fixed.
- if (arguments.contains("--failure-summary")) {
- arguments = arguments.where((arg) => arg != "--failure-summary").toList();
- print('Note: Ignoring unsupported "--failure-summary" option.');
- }
-
var configuration = <String, dynamic>{};
// Fill in configuration with arguments passed to the test script.
« no previous file with comments | « tools/bots/run_android_tests.sh ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698