Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(16)

Issue 2916123002: Remove temp code to ignore "--failure-summary". (Closed)

Created:
3 years, 6 months ago by Bob Nystrom
Modified:
3 years, 6 months ago
Reviewers:
Bill Hesse
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Remove temp code to ignore "--failure-summary". Now that the BuildBots aren't passing it, we don't need to accept it. R=whesse@google.com Committed: https://github.com/dart-lang/sdk/commit/db063249750250985e7bf72c08ce63b76585cbae

Patch Set 1 #

Patch Set 2 : Merge branch 'master' into failure-summary-flag #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -9 lines) Patch
M tools/bots/run_android_tests.sh View 1 1 chunk +1 line, -1 line 0 comments Download
M tools/testing/dart/options.dart View 1 chunk +0 lines, -8 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
Bob Nystrom
I still the flag being passed in some of the latest buildbot results but I'm ...
3 years, 6 months ago (2017-06-01 16:38:26 UTC) #2
Bill Hesse
lgtm
3 years, 6 months ago (2017-06-01 16:50:12 UTC) #3
Bob Nystrom
3 years, 6 months ago (2017-06-01 22:46:00 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
db063249750250985e7bf72c08ce63b76585cbae (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698