Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(343)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2916093003: Add the more complex LUB test. (Closed)

Created:
3 years, 6 months ago by scheglov
Modified:
3 years, 6 months ago
Reviewers:
ahe, Paul Berry
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Add the more complex LUB test. Peter asked to a more complex test. R=ahe@google.com, paulberry@google.com BUG= Committed: https://github.com/dart-lang/sdk/commit/717937a1803709463ad9dccd4eca339cad6393b9

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+78 lines, -0 lines) Patch
M pkg/kernel/test/class_hierarchy_test.dart View 2 chunks +78 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
scheglov
3 years, 6 months ago (2017-06-01 21:43:34 UTC) #1
Paul Berry
lgtm
3 years, 6 months ago (2017-06-01 21:44:57 UTC) #2
scheglov
Committed patchset #1 (id:1) manually as 717937a1803709463ad9dccd4eca339cad6393b9 (presubmit successful).
3 years, 6 months ago (2017-06-01 21:46:26 UTC) #4
ahe
3 years, 6 months ago (2017-06-02 11:36:52 UTC) #5
Message was sent while issue was closed. 
lgtm

Powered by Google App Engine
This is Rietveld 408576698