Use 'outline.dill' instead of 'platform.dill' in kernel isolate

Use 'outline.dill' instead of 'platform.dill' in kernel isolate

R=ahe@google.com, sigmund@google.com

Committed: https://github.com/dart-lang/sdk/commit/303ab0aa96da2dd530270b3beb8af1fba3881e1d

[Dmitry Stefantsov, 2017-06-01 13:56:54]

dmitryas@google.com changed reviewers:
+ sigmund@google.com

[Dmitry Stefantsov, 2017-06-01 13:56:55]

Hi Siggi and Peter,

Siggi, I remember you wanted to switch to 'outline.dill' from 'platform.dill' in
the kernel isolate. It actually would solve some of the issues I'm dealing with.
So, I tried to do the switch, and it just worked :) Please, take a look and let
me know if I missed something.

Peter, it would be great to also know your opinion about the change.

Thanks!

[ahe, 2017-06-01 14:01:11]

ahe@google.com changed reviewers:
+ ahe@google.com

[ahe, 2017-06-01 14:01:12]

lgtm

[Siggi Cherem (dart-lang), 2017-06-01 18:07:34]

lgtm

One idea might be to add a check in kernel-service.dart to ensure that when the
--dfe flag is passed, we also specify the --platform flag (otherwise we know
that the dfe will create an incomplete program). We should be able to check that
just by reading Platform.executableArguments.

[Siggi Cherem (dart-lang), 2017-06-01 18:08:21]

On 2017/06/01 18:07:34, Siggi Cherem (dart-lang) wrote:
> lgtm
> 
> One idea might be to add a check in kernel-service.dart to ensure that when
the
> --dfe flag is passed, we also specify the --platform flag (otherwise we know
> that the dfe will create an incomplete program). We should be able to check
that
> just by reading Platform.executableArguments.

mmm - right now it appears that without the --platform flag the kernel-service
is not happy anyways, so maybe this extra check is not necessary anyways.

[Dmitry Stefantsov, 2017-06-02 08:54:08]

Description was changed from

==========
Use 'outline.dill' instead of 'platform.dill' in kernel isolate
==========

to

==========
Use 'outline.dill' instead of 'platform.dill' in kernel isolate

R=ahe@google.com, sigmund@google.com

Committed:
https://github.com/dart-lang/sdk/commit/303ab0aa96da2dd530270b3beb8af1fba3881e1d
==========

[Dmitry Stefantsov, 2017-06-02 08:54:09]

Committed patchset #2 (id:20001) manually as
303ab0aa96da2dd530270b3beb8af1fba3881e1d (presubmit successful).

[Dmitry Stefantsov, 2017-06-02 09:07:02]

On 2017/06/01 18:08:21, Siggi Cherem (dart-lang) wrote:
> On 2017/06/01 18:07:34, Siggi Cherem (dart-lang) wrote:
> > lgtm
> > 
> > One idea might be to add a check in kernel-service.dart to ensure that when
> the
> > --dfe flag is passed, we also specify the --platform flag (otherwise we know
> > that the dfe will create an incomplete program). We should be able to check
> that
> > just by reading Platform.executableArguments.
> 
> mmm - right now it appears that without the --platform flag the kernel-service
> is not happy anyways, so maybe this extra check is not necessary anyways.

Thanks for the reply, Siggi! Indeed, the --platform flag seems to be mandatory
when --dfe is used.