Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(77)

Side by Side Diff: third_party/WebKit/Source/core/frame/LocalFrameTest.cpp

Issue 2916043002: Move LocalFrame::DragImageForSelection DragController (Closed)
Patch Set: updated Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2016 The Chromium Authors. All rights reserved. 1 // Copyright 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4
5 #include "core/frame/LocalFrame.h" 4 #include "core/frame/LocalFrame.h"
6 5
6 #include "core/clipboard/DataTransfer.h"
7 #include "core/editing/FrameSelection.h" 7 #include "core/editing/FrameSelection.h"
8 #include "core/frame/LocalFrameView.h" 8 #include "core/frame/LocalFrameView.h"
9 #include "core/frame/PerformanceMonitor.h" 9 #include "core/frame/PerformanceMonitor.h"
10 #include "core/frame/VisualViewport.h" 10 #include "core/frame/VisualViewport.h"
11 #include "core/html/HTMLElement.h" 11 #include "core/html/HTMLElement.h"
12 #include "core/layout/LayoutObject.h" 12 #include "core/layout/LayoutObject.h"
13 #include "core/page/DragController.h"
13 #include "core/testing/DummyPageHolder.h" 14 #include "core/testing/DummyPageHolder.h"
14 #include "core/timing/Performance.h" 15 #include "core/timing/Performance.h"
15 #include "platform/DragImage.h" 16 #include "platform/DragImage.h"
16 #include "testing/gtest/include/gtest/gtest.h" 17 #include "testing/gtest/include/gtest/gtest.h"
17 18
18 namespace blink { 19 namespace blink {
19 20
20 class LocalFrameTest : public ::testing::Test { 21 class LocalFrameTest : public ::testing::Test {
21 protected: 22 protected:
22 LocalFrameTest() = default; 23 LocalFrameTest() = default;
(...skipping 22 matching lines...) Expand all
45 Persistent<Performance> performance_; 46 Persistent<Performance> performance_;
46 }; 47 };
47 48
48 TEST_F(LocalFrameTest, nodeImage) { 49 TEST_F(LocalFrameTest, nodeImage) {
49 SetBodyContent( 50 SetBodyContent(
50 "<style>" 51 "<style>"
51 "#sample { width: 100px; height: 100px; }" 52 "#sample { width: 100px; height: 100px; }"
52 "</style>" 53 "</style>"
53 "<div id=sample></div>"); 54 "<div id=sample></div>");
54 Element* sample = GetDocument().getElementById("sample"); 55 Element* sample = GetDocument().getElementById("sample");
55 const std::unique_ptr<DragImage> image = GetFrame().NodeImage(*sample); 56 const std::unique_ptr<DragImage> image =
57 DataTransfer::NodeImage(GetFrame(), *sample);
Xiaocheng 2017/06/02 18:26:47 Let's create a DataTransferTest for these unit tes
56 EXPECT_EQ(IntSize(100, 100), image->Size()); 58 EXPECT_EQ(IntSize(100, 100), image->Size());
57 } 59 }
58 60
59 TEST_F(LocalFrameTest, nodeImageWithNestedElement) { 61 TEST_F(LocalFrameTest, nodeImageWithNestedElement) {
60 SetBodyContent( 62 SetBodyContent(
61 "<style>" 63 "<style>"
62 "div { -webkit-user-drag: element }" 64 "div { -webkit-user-drag: element }"
63 "span:-webkit-drag { color: #0F0 }" 65 "span:-webkit-drag { color: #0F0 }"
64 "</style>" 66 "</style>"
65 "<div id=sample><span>Green when dragged</span></div>"); 67 "<div id=sample><span>Green when dragged</span></div>");
66 Element* sample = GetDocument().getElementById("sample"); 68 Element* sample = GetDocument().getElementById("sample");
67 const std::unique_ptr<DragImage> image = GetFrame().NodeImage(*sample); 69 const std::unique_ptr<DragImage> image =
70 DataTransfer::NodeImage(GetFrame(), *sample);
68 EXPECT_EQ( 71 EXPECT_EQ(
69 Color(0, 255, 0), 72 Color(0, 255, 0),
70 sample->firstChild()->GetLayoutObject()->ResolveColor(CSSPropertyColor)) 73 sample->firstChild()->GetLayoutObject()->ResolveColor(CSSPropertyColor))
71 << "Descendants node should have :-webkit-drag."; 74 << "Descendants node should have :-webkit-drag.";
72 } 75 }
73 76
74 TEST_F(LocalFrameTest, nodeImageWithPsuedoClassWebKitDrag) { 77 TEST_F(LocalFrameTest, nodeImageWithPsuedoClassWebKitDrag) {
75 SetBodyContent( 78 SetBodyContent(
76 "<style>" 79 "<style>"
77 "#sample { width: 100px; height: 100px; }" 80 "#sample { width: 100px; height: 100px; }"
78 "#sample:-webkit-drag { width: 200px; height: 200px; }" 81 "#sample:-webkit-drag { width: 200px; height: 200px; }"
79 "</style>" 82 "</style>"
80 "<div id=sample></div>"); 83 "<div id=sample></div>");
81 Element* sample = GetDocument().getElementById("sample"); 84 Element* sample = GetDocument().getElementById("sample");
82 const std::unique_ptr<DragImage> image = GetFrame().NodeImage(*sample); 85 const std::unique_ptr<DragImage> image =
86 DataTransfer::NodeImage(GetFrame(), *sample);
83 EXPECT_EQ(IntSize(200, 200), image->Size()) 87 EXPECT_EQ(IntSize(200, 200), image->Size())
84 << ":-webkit-drag should affect dragged image."; 88 << ":-webkit-drag should affect dragged image.";
85 } 89 }
86 90
87 TEST_F(LocalFrameTest, nodeImageWithoutDraggedLayoutObject) { 91 TEST_F(LocalFrameTest, nodeImageWithoutDraggedLayoutObject) {
88 SetBodyContent( 92 SetBodyContent(
89 "<style>" 93 "<style>"
90 "#sample { width: 100px; height: 100px; }" 94 "#sample { width: 100px; height: 100px; }"
91 "#sample:-webkit-drag { display:none }" 95 "#sample:-webkit-drag { display:none }"
92 "</style>" 96 "</style>"
93 "<div id=sample></div>"); 97 "<div id=sample></div>");
94 Element* sample = GetDocument().getElementById("sample"); 98 Element* sample = GetDocument().getElementById("sample");
95 const std::unique_ptr<DragImage> image = GetFrame().NodeImage(*sample); 99 const std::unique_ptr<DragImage> image =
100 DataTransfer::NodeImage(GetFrame(), *sample);
96 EXPECT_EQ(nullptr, image.get()) << ":-webkit-drag blows away layout object"; 101 EXPECT_EQ(nullptr, image.get()) << ":-webkit-drag blows away layout object";
97 } 102 }
98 103
99 TEST_F(LocalFrameTest, nodeImageWithChangingLayoutObject) { 104 TEST_F(LocalFrameTest, nodeImageWithChangingLayoutObject) {
100 SetBodyContent( 105 SetBodyContent(
101 "<style>" 106 "<style>"
102 "#sample { color: blue; }" 107 "#sample { color: blue; }"
103 "#sample:-webkit-drag { display: inline-block; color: red; }" 108 "#sample:-webkit-drag { display: inline-block; color: red; }"
104 "</style>" 109 "</style>"
105 "<span id=sample>foo</span>"); 110 "<span id=sample>foo</span>");
106 Element* sample = GetDocument().getElementById("sample"); 111 Element* sample = GetDocument().getElementById("sample");
107 UpdateAllLifecyclePhases(); 112 UpdateAllLifecyclePhases();
108 LayoutObject* before_layout_object = sample->GetLayoutObject(); 113 LayoutObject* before_layout_object = sample->GetLayoutObject();
109 const std::unique_ptr<DragImage> image = GetFrame().NodeImage(*sample); 114 const std::unique_ptr<DragImage> image =
115 DataTransfer::NodeImage(GetFrame(), *sample);
110 116
111 EXPECT_TRUE(sample->GetLayoutObject() != before_layout_object) 117 EXPECT_TRUE(sample->GetLayoutObject() != before_layout_object)
112 << ":-webkit-drag causes sample to have different layout object."; 118 << ":-webkit-drag causes sample to have different layout object.";
113 EXPECT_EQ(Color(255, 0, 0), 119 EXPECT_EQ(Color(255, 0, 0),
114 sample->GetLayoutObject()->ResolveColor(CSSPropertyColor)) 120 sample->GetLayoutObject()->ResolveColor(CSSPropertyColor))
115 << "#sample has :-webkit-drag."; 121 << "#sample has :-webkit-drag.";
116 122
117 // Layout w/o :-webkit-drag 123 // Layout w/o :-webkit-drag
118 UpdateAllLifecyclePhases(); 124 UpdateAllLifecyclePhases();
119 125
120 EXPECT_EQ(Color(0, 0, 255), 126 EXPECT_EQ(Color(0, 0, 255),
121 sample->GetLayoutObject()->ResolveColor(CSSPropertyColor)) 127 sample->GetLayoutObject()->ResolveColor(CSSPropertyColor))
122 << "#sample doesn't have :-webkit-drag."; 128 << "#sample doesn't have :-webkit-drag.";
123 } 129 }
124 130
125 TEST_F(LocalFrameTest, dragImageForSelectionUsesPageScaleFactor) { 131 TEST_F(LocalFrameTest, dragImageForSelectionUsesPageScaleFactor) {
126 SetBodyContent( 132 SetBodyContent(
127 "<div>Hello world! This tests that the bitmap for drag image is scaled " 133 "<div>Hello world! This tests that the bitmap for drag image is scaled "
128 "by page scale factor</div>"); 134 "by page scale factor</div>");
129 GetFrame().GetPage()->GetVisualViewport().SetScale(1); 135 GetFrame().GetPage()->GetVisualViewport().SetScale(1);
130 GetFrame().Selection().SelectAll(); 136 GetFrame().Selection().SelectAll();
131 UpdateAllLifecyclePhases(); 137 UpdateAllLifecyclePhases();
132 const std::unique_ptr<DragImage> image1( 138 const std::unique_ptr<DragImage> image1(
133 GetFrame().DragImageForSelection(0.75f)); 139 DragController::DragImageForSelection(&GetFrame(), 0.75f));
Xiaocheng 2017/06/02 18:26:47 Let's create a DragControllerTest for these unit t
134 GetFrame().GetPage()->GetVisualViewport().SetScale(2); 140 GetFrame().GetPage()->GetVisualViewport().SetScale(2);
135 GetFrame().Selection().SelectAll(); 141 GetFrame().Selection().SelectAll();
136 UpdateAllLifecyclePhases(); 142 UpdateAllLifecyclePhases();
137 const std::unique_ptr<DragImage> image2( 143 const std::unique_ptr<DragImage> image2(
138 GetFrame().DragImageForSelection(0.75f)); 144 DragController::DragImageForSelection(&GetFrame(), 0.75f));
139 145
140 EXPECT_GT(image1->Size().Width(), 0); 146 EXPECT_GT(image1->Size().Width(), 0);
141 EXPECT_GT(image1->Size().Height(), 0); 147 EXPECT_GT(image1->Size().Height(), 0);
142 EXPECT_EQ(image1->Size().Width() * 2, image2->Size().Width()); 148 EXPECT_EQ(image1->Size().Width() * 2, image2->Size().Width());
143 EXPECT_EQ(image1->Size().Height() * 2, image2->Size().Height()); 149 EXPECT_EQ(image1->Size().Height() * 2, image2->Size().Height());
144 } 150 }
145 151
146 } // namespace blink 152 } // namespace blink
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698