chrome/browser/page_load_metrics/observers/service_worker_page_load_metrics_observer.h - Issue 2916033002: Add page/document timing UMAs for search without service worker

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/page_load_metrics/observers/service_worker_page_load_metrics_observer.h

Issue 2916033002: Add page/document timing UMAs for search without service worker (Closed)

Patch Set: incorporated falken's comment Created 3 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « no previous file | chrome/browser/page_load_metrics/observers/service_worker_page_load_metrics_observer.cc » ('j') | tools/metrics/histograms/histograms.xml » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/page_load_metrics/observers/service_worker_page_load_metrics_observer.h

diff --git a/chrome/browser/page_load_metrics/observers/service_worker_page_load_metrics_observer.h b/chrome/browser/page_load_metrics/observers/service_worker_page_load_metrics_observer.h

index b6b974d3a6278ea98267ae1122a85eedbaebfca1..79ac7e2eba480bd0d8c1e96dd8567bbccdc7d374 100644

--- a/chrome/browser/page_load_metrics/observers/service_worker_page_load_metrics_observer.h

+++ b/chrome/browser/page_load_metrics/observers/service_worker_page_load_metrics_observer.h

@@ -39,6 +39,15 @@ extern const char

extern const char kHistogramServiceWorkerDomContentLoadedSearch[];

extern const char kHistogramServiceWorkerLoadSearch[];

+extern const char kHistogramServiceWorkerFirstContentfulPaintSearchNoSW[];

+extern const char kHistogramServiceWorkerFirstMeaningfulPaintSearchNoSW[];

+extern const char

+ kHistogramServiceWorkerParseStartToFirstMeaningfulPaintSearchNoSW[];

+extern const char

+ kHistogramServiceWorkerParseStartToFirstContentfulPaintSearchNoSW[];

+extern const char kHistogramServiceWorkerDomContentLoadedSearchNoSW[];

+extern const char kHistogramServiceWorkerLoadSearchNoSW[];

} // namespace internal

class ServiceWorkerPageLoadMetricsObserver