tools/metrics/histograms/histograms.xml - Issue 2916033002: Add page/document timing UMAs for search without service worker

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/metrics/histograms/histograms.xml

Side-by-side diff isn't available for this file because of its large size.

Issue 2916033002: Add page/document timing UMAs for search without service worker (Closed)

Patch Set: incorporated falken's comment Created 3 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: tools/metrics/histograms/histograms.xml

diff --git a/tools/metrics/histograms/histograms.xml b/tools/metrics/histograms/histograms.xml

index 3c693441c30915f49c2b6f9cfb23b51caa01d1ae..5c1385fd217b96fc5434aeecf6afada08dd69e41 100644

--- a/tools/metrics/histograms/histograms.xml

+++ b/tools/metrics/histograms/histograms.xml

@@ -91832,8 +91832,8 @@ http://cs/file:chrome/histograms.xml - but prefer this file for new entries.

<histogram_suffixes name="PageLoadMetricsClientsServiceWorker" separator="."

ordering="prefix">

<suffix name="Clients.ServiceWorker"

- label="PageLoadMetrics from a page that is controlled by a Service

- Worker"/>

+ label="PageLoadMetrics from a page that is controlled by a service

+ worker, unless otherwise specified"/>

Mark P 2017/06/07 16:15:02 This phrasing makes me think that you're changing

<affected-histogram

name="PageLoad.DocumentTiming.NavigationToDOMContentLoadedEventFired"/>

<affected-histogram

@@ -91857,7 +91857,12 @@ http://cs/file:chrome/histograms.xml - but prefer this file for new entries.

<histogram_suffixes name="PageLoadMetricsClientsServiceWorkerSpecialApps"

separator=".">

- <suffix name="search" label="Custom histogram for Search"/>

+ <suffix name="search"

+ label="Custom histogram for the Google Search results page"/>

+ <suffix name="search_no_sw"

+ label="Custom histogram for the Google Search results page when NOT

+ controlled by a service worker. The ancestor histograms above

+ '.search_no_sw' are not recorded."/>

Mark P 2017/06/07 16:15:02 I don't understand this last sentence. Can you re

<affected-histogram

name="PageLoad.Clients.ServiceWorker.DocumentTiming.NavigationToDOMContentLoadedEventFired"/>

<affected-histogram