Don't try to reload blacklisted extensions.

chrome/browser/extensions/extension_service.h

Index: chrome/browser/extensions/extension_service.h
diff --git a/chrome/browser/extensions/extension_service.h b/chrome/browser/extensions/extension_service.h
index bc058c06621c9104e401d21aefd2eda3e54b6dc8..f7cb817f7016c77b97f4b496ef7bdbfc61ea7149 100644
--- a/chrome/browser/extensions/extension_service.h
+++ b/chrome/browser/extensions/extension_service.h
@@ -193,7 +193,7 @@ class ExtensionService
 
   // Reloads the specified extension, sending the onLaunched() event to it if it
   // currently has any window showing.
-  void ReloadExtension(const std::string extension_id);
+  void ReloadExtension(const std::string& extension_id);

[Marijn Kruisselbrink, 2014/05/19 20:10:32]

Is this safe? Presumably the same comment as in UninstallExtension below applies
("We pass the |extension_id| by value to avoid having it deleted from under us
incase someone calls it with Extension::id() or another string that we are going
to delete in this function.")

Although it seems somebody recently (incorrectly?) changed the
UninstallExtension paramtere to be a reference in
https://src.chromium.org/viewvc/chrome?revision=267343&view=revision without
updating the comment.

[not at google - send to devlin, 2014/05/19 20:32:10]

Ah. Good point, very subtle.

"const std::string" without the reference is nonsensical and confusing. I don't
think it's great as a concern of the interface to this class. Seems kind of
flaky. I'll update the implementations to be safe in this regard.

 
   // Uninstalls the specified extension. Callers should only call this method
   // with extensions that exist. |external_uninstall| is a magical parameter
@@ -707,8 +707,8 @@ class ExtensionService
                            UnloadBlacklistedExtensionPolicy);
   FRIEND_TEST_ALL_PREFIXES(ExtensionServiceTest,
                            WillNotLoadBlacklistedExtensionsFromDirectory);
-  FRIEND_TEST_ALL_PREFIXES(ExtensionServiceTest,
-                           BlacklistedInPrefsFromStartup);
+  FRIEND_TEST_ALL_PREFIXES(ExtensionServiceTest, ReloadBlacklistedExtension);
+  FRIEND_TEST_ALL_PREFIXES(ExtensionServiceTest, BlacklistedInPrefsFromStartup);
   FRIEND_TEST_ALL_PREFIXES(ExtensionServiceTest,
                            GreylistedExtensionDisabled);
   FRIEND_TEST_ALL_PREFIXES(ExtensionServiceTest,