Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(288)

Issue 2916023004: Make pkg/dart_messages strong. (Closed)

Created:
3 years, 6 months ago by devoncarew
Modified:
3 years, 6 months ago
Reviewers:
Paul Berry, floitsch
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -4 lines) Patch
A pkg/dart_messages/analysis_options.yaml View 1 chunk +2 lines, -0 lines 0 comments Download
M pkg/dart_messages/bin/message_id.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M pkg/dart_messages/bin/publish.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/dart_messages/test/dart_messages_test.dart View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5 (2 generated)
devoncarew
Make pkg/dart_messages strong. Also, use 'package:dart_messages/' self-references to refer to code in the lib/ directory.
3 years, 6 months ago (2017-06-02 22:37:17 UTC) #2
Paul Berry
lgtm
3 years, 6 months ago (2017-06-03 13:19:30 UTC) #3
devoncarew
3 years, 6 months ago (2017-06-09 04:55:13 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
303efec911ec6b1d666ec935c40342b1060fc05f (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698