Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(51)

Issue 2915993003: Revert of [scheduler] Change TaskQueue observer call mechanism. (Closed)

Created:
3 years, 6 months ago by shimazu
Modified:
3 years, 6 months ago
CC:
chromium-reviews, blink-reviews, kinuko+watch, scheduler-bugs_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of [scheduler] Change TaskQueue observer call mechanism. (patchset #6 id:100001 of https://codereview.chromium.org/2808843003/ ) Reason for revert: This looks causing failure of loading pages when launching the process. For example, twitter lite cannot be open from the home screen because the hosting service worker probably cannot run on a process. See also https://crbug.com/725337. Original issue's description: > [scheduler] Change TaskQueue observer call mechanism. > > Instead of manually calling TaskQueue observer we can rely on TimeDomain > calling SetScheduledTimeDomainWakeUp and we can call the observer from > there. > > This patch also fixes the problem where pages were stuck due to a missing > notification. Test coverage is improved and HasPendingImmediateWork renamed > to HasTaskToRunImmediately to better reflect its meaning. > > R=alexclarke@chromium.org,skyostil@chromium.org > BUG=699541, 710095 > > Review-Url: https://codereview.chromium.org/2808843003 > Cr-Commit-Position: refs/heads/master@{#470957} > Committed: https://chromium.googlesource.com/chromium/src/+/0f67a0c1b7f0e461114771b4297f5fc0a0202cee TBR=alexclarke@chromium.org,skyostil@chromium.org,altimin@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=699541, 710095

Patch Set 1 #

Messages

Total messages: 6 (3 generated)
shimazu
Created Revert of [scheduler] Change TaskQueue observer call mechanism.
3 years, 6 months ago (2017-06-01 03:35:12 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2915993003/1
3 years, 6 months ago (2017-06-01 03:35:32 UTC) #3
shimazu
3 years, 6 months ago (2017-06-01 04:22:32 UTC) #5
I found ToT chromium without this revert commit also works well locally while
canary doesn't work. This might not be related to the issue.
Let me stop to send this to CQ for now. Sorry for confusing.

Powered by Google App Engine
This is Rietveld 408576698