net/quic/chromium/bidirectional_stream_quic_impl.h - Issue 2915973002: Fix potential crash bug with BidirectionalStreamQuicImpl::SendRequestHeaders

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: net/quic/chromium/bidirectional_stream_quic_impl.h

Issue 2915973002: Fix potential crash bug with BidirectionalStreamQuicImpl::SendRequestHeaders (Closed)

Patch Set: Rebase Created 3 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
1 // Copyright 2016 The Chromium Authors. All rights reserved.	1 // Copyright 2016 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 #ifndef NET_QUIC_CHROMIUM_BIDIRECTIONAL_STREAM_QUIC_IMPL_H_	5 #ifndef NET_QUIC_CHROMIUM_BIDIRECTIONAL_STREAM_QUIC_IMPL_H_

6 #define NET_QUIC_CHROMIUM_BIDIRECTIONAL_STREAM_QUIC_IMPL_H_	6 #define NET_QUIC_CHROMIUM_BIDIRECTIONAL_STREAM_QUIC_IMPL_H_

7	7

8 #include <stdint.h>	8 #include <stdint.h>

9	9

10 #include <memory>	10 #include <memory>

(...skipping 43 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
54 NextProto GetProtocol() const override;	54 NextProto GetProtocol() const override;

55 int64_t GetTotalReceivedBytes() const override;	55 int64_t GetTotalReceivedBytes() const override;

56 int64_t GetTotalSentBytes() const override;	56 int64_t GetTotalSentBytes() const override;

57 bool GetLoadTimingInfo(LoadTimingInfo* load_timing_info) const override;	57 bool GetLoadTimingInfo(LoadTimingInfo* load_timing_info) const override;

58	58

59 private:	59 private:

60 // QuicChromiumClientStream::Delegate implementation:	60 // QuicChromiumClientStream::Delegate implementation:

61 void OnClose() override;	61 void OnClose() override;

62 void OnError(int error) override;	62 void OnError(int error) override;

63	63

	64 bool WriteHeaders();

64 void OnStreamReady(int rv);	65 void OnStreamReady(int rv);

65 void OnSendDataComplete(int rv);	66 void OnSendDataComplete(int rv);

66 void ReadInitialHeaders();	67 void ReadInitialHeaders();

67 void OnReadInitialHeadersComplete(int rv);	68 void OnReadInitialHeadersComplete(int rv);

68 void ReadTrailingHeaders();	69 void ReadTrailingHeaders();

69 void OnReadTrailingHeadersComplete(int rv);	70 void OnReadTrailingHeadersComplete(int rv);

70 void OnReadDataComplete(int rv);	71 void OnReadDataComplete(int rv);

71	72

72 // Notifies the delegate of an error.	73 // Notifies the delegate of an error.

73 void NotifyError(int error);	74 void NotifyError(int error);

(...skipping 49 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
123 bool send_request_headers_automatically_;	124 bool send_request_headers_automatically_;

124	125

125 base::WeakPtrFactory<BidirectionalStreamQuicImpl> weak_factory_;	126 base::WeakPtrFactory<BidirectionalStreamQuicImpl> weak_factory_;

126	127

127 DISALLOW_COPY_AND_ASSIGN(BidirectionalStreamQuicImpl);	128 DISALLOW_COPY_AND_ASSIGN(BidirectionalStreamQuicImpl);

128 };	129 };

129	130

130 } // namespace net	131 } // namespace net

131	132

132 #endif // NET_QUIC_CHROMIUM_BIDIRECTIONAL_STREAM_QUIC_IMPL_H_	133 #endif // NET_QUIC_CHROMIUM_BIDIRECTIONAL_STREAM_QUIC_IMPL_H_

OLD	NEW

« no previous file with comments | « no previous file | net/quic/chromium/bidirectional_stream_quic_impl.cc » ('j') | net/quic/chromium/bidirectional_stream_quic_impl_unittest.cc » ('J')