Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(682)

Unified Diff: chrome/browser/banners/app_banner_manager.cc

Issue 2915913002: [WebAPKs] Display same text for menu & engagement banner (Closed)
Patch Set: Merge branch 'master' into same_infobar_title Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/banners/app_banner_manager.cc
diff --git a/chrome/browser/banners/app_banner_manager.cc b/chrome/browser/banners/app_banner_manager.cc
index 9524f7eff2093ecb1489a53631f279852a4d1392..114cc214c48427027a65af10013fbe4db7b4e272 100644
--- a/chrome/browser/banners/app_banner_manager.cc
+++ b/chrome/browser/banners/app_banner_manager.cc
@@ -220,13 +220,6 @@ void AppBannerManager::OnDidGetManifest(const InstallableData& data) {
manifest_url_ = data.manifest_url;
manifest_ = data.manifest;
- // One of manifest_.name or manifest_.short_name must be non-null and
- // non-empty if the error code was NO_ERROR_DETECTED.
- if (manifest_.name.is_null() || manifest_.name.string().empty())
- app_title_ = manifest_.short_name.string();
- else
- app_title_ = manifest_.name.string();
-
PerformInstallableCheck();
}

Powered by Google App Engine
This is Rietveld 408576698