chrome/browser/android/webapk/webapk_installer.cc - Issue 2915913002: [WebAPKs] Display same text for menu & engagement banner

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/android/webapk/webapk_installer.cc

Issue 2915913002: [WebAPKs] Display same text for menu & engagement banner (Closed)

Patch Set: Merge branch 'master' into same_infobar_title Created 3 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/android/webapk/webapk_installer.cc

diff --git a/chrome/browser/android/webapk/webapk_installer.cc b/chrome/browser/android/webapk/webapk_installer.cc

index 31966bd9cc7c8962be0be72ec78456a571b4905e..acdd4798cfd937a126dff357613648718995b3a2 100644

--- a/chrome/browser/android/webapk/webapk_installer.cc

+++ b/chrome/browser/android/webapk/webapk_installer.cc

@@ -283,7 +283,7 @@ void WebApkInstaller::InstallOrUpdateWebApk(const std::string& package_name,

base::android::ScopedJavaLocalRef<jstring> java_webapk_package =

base::android::ConvertUTF8ToJavaString(env, webapk_package_);

base::android::ScopedJavaLocalRef<jstring> java_title =

- base::android::ConvertUTF16ToJavaString(env, shortcut_info_.user_title);

+ base::android::ConvertUTF16ToJavaString(env, shortcut_info_.short_name);

base::android::ScopedJavaLocalRef<jstring> java_token =

base::android::ConvertUTF8ToJavaString(env, token);

base::android::ScopedJavaLocalRef<jstring> java_url =