Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(291)

Unified Diff: chrome/browser/android/banners/app_banner_manager_android.cc

Issue 2915913002: [WebAPKs] Display same text for menu & engagement banner (Closed)
Patch Set: Merge branch 'master' into same_infobar_title Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/android/banners/app_banner_manager_android.cc
diff --git a/chrome/browser/android/banners/app_banner_manager_android.cc b/chrome/browser/android/banners/app_banner_manager_android.cc
index cd8c740576e86460f94fe0f07c0edcce2effccb3..f50e444cf6cea7165e1d9e932287d927168345db 100644
--- a/chrome/browser/android/banners/app_banner_manager_android.cc
+++ b/chrome/browser/android/banners/app_banner_manager_android.cc
@@ -112,7 +112,7 @@ bool AppBannerManagerAndroid::OnAppDetailsRetrieved(
const JavaParamRef<jstring>& japp_package,
const JavaParamRef<jstring>& jicon_url) {
native_app_data_.Reset(japp_data);
- app_title_ = ConvertJavaStringToUTF16(env, japp_title);
+ native_app_title_ = ConvertJavaStringToUTF16(env, japp_title);
native_app_package_ = ConvertJavaStringToUTF8(env, japp_package);
primary_icon_url_ = GURL(ConvertJavaStringToUTF8(env, jicon_url));
@@ -246,7 +246,7 @@ void AppBannerManagerAndroid::ShowBanner() {
if (native_app_data_.is_null()) {
if (AppBannerInfoBarDelegateAndroid::Create(
- contents, GetWeakPtr(), app_title_,
+ contents, GetWeakPtr(),
CreateShortcutInfo(manifest_url_, manifest_, primary_icon_url_,
badge_icon_url_, can_install_webapk_),
primary_icon_, badge_icon_, event_request_id(), can_install_webapk_,
@@ -259,7 +259,7 @@ void AppBannerManagerAndroid::ShowBanner() {
}
} else {
if (AppBannerInfoBarDelegateAndroid::Create(
- contents, app_title_, native_app_data_, primary_icon_,
+ contents, native_app_title_, native_app_data_, primary_icon_,
native_app_package_, referrer_, event_request_id())) {
RecordDidShowBanner("AppBanner.NativeApp.Shown");
TrackDisplayEvent(DISPLAY_EVENT_NATIVE_APP_BANNER_CREATED);

Powered by Google App Engine
This is Rietveld 408576698