chrome/android/java/src/org/chromium/chrome/browser/download/DownloadUtils.java - Issue 2915863002: Photo Picker dialog: Add UMA statistics.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/download/DownloadUtils.java

Issue 2915863002: Photo Picker dialog: Add UMA statistics. (Closed)

Patch Set: Address feedback from Theresa Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « no previous file | chrome/android/java/src/org/chromium/chrome/browser/photo_picker/BitmapScalerTask.java » ('j') | chrome/android/java/src/org/chromium/chrome/browser/photo_picker/DecoderServiceHost.java » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/java/src/org/chromium/chrome/browser/download/DownloadUtils.java

diff --git a/chrome/android/java/src/org/chromium/chrome/browser/download/DownloadUtils.java b/chrome/android/java/src/org/chromium/chrome/browser/download/DownloadUtils.java

index 823307dc73ca9b4b5ce22a2b6e785918be5ddb97..98edde1d68c3a6c25d3c9c4a1d1cd35bcc694e7f 100644

--- a/chrome/android/java/src/org/chromium/chrome/browser/download/DownloadUtils.java

+++ b/chrome/android/java/src/org/chromium/chrome/browser/download/DownloadUtils.java

@@ -94,9 +94,9 @@ public class DownloadUtils {

private static final String EXTRA_IS_OFF_THE_RECORD =

"org.chromium.chrome.browser.download.IS_OFF_THE_RECORD";

- private static final long BYTES_PER_KILOBYTE = 1024;

- private static final long BYTES_PER_MEGABYTE = 1024 * 1024;

- private static final long BYTES_PER_GIGABYTE = 1024 * 1024 * 1024;

+ public static final int BYTES_PER_KILOBYTE = 1024;

+ public static final int BYTES_PER_MEGABYTE = 1024 * 1024;

+ public static final int BYTES_PER_GIGABYTE = 1024 * 1024 * 1024;

Theresa 2017/06/01 15:58:04 These should move to a place that makes sense for

@VisibleForTesting

static final long SECONDS_PER_MINUTE = TimeUnit.MINUTES.toSeconds(1);