Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1344)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/photo_picker/DecoderService.java

Issue 2915863002: Photo Picker dialog: Add UMA statistics. (Closed)
Patch Set: Address feedback from Mark Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/java/src/org/chromium/chrome/browser/photo_picker/DecoderService.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/photo_picker/DecoderService.java b/chrome/android/java/src/org/chromium/chrome/browser/photo_picker/DecoderService.java
index 0cd771357afa349fa3279c89740e24fce0a2edc4..9f307683bb5558327b1ad5405d2d2108b72c895b 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/photo_picker/DecoderService.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/photo_picker/DecoderService.java
@@ -14,6 +14,7 @@ import android.os.Message;
import android.os.Messenger;
import android.os.ParcelFileDescriptor;
import android.os.RemoteException;
+import android.os.SystemClock;
import org.chromium.base.Log;
@@ -39,6 +40,7 @@ public class DecoderService extends Service {
static final String KEY_IMAGE_DESCRIPTOR = "image_descriptor";
static final String KEY_SIZE = "size";
static final String KEY_SUCCESS = "success";
+ static final String KEY_DECODE_TIME = "decode_time";
// A tag for logging error messages.
private static final String TAG = "ImageDecoder";
@@ -70,7 +72,11 @@ public class DecoderService extends Service {
bundle.putBoolean(KEY_SUCCESS, false);
FileDescriptor fd = pfd.getFileDescriptor();
+
+ long begin = SystemClock.elapsedRealtime();
Bitmap bitmap = BitmapUtils.decodeBitmapFromFileDescriptor(fd, size);
+ long decodeTime = SystemClock.elapsedRealtime() - begin;
+
try {
pfd.close();
} catch (IOException e) {
@@ -90,6 +96,7 @@ public class DecoderService extends Service {
// ashmem since it's immutable and carry on.
bundle.putParcelable(KEY_IMAGE_BITMAP, bitmap);
bundle.putBoolean(KEY_SUCCESS, true);
+ bundle.putLong(KEY_DECODE_TIME, decodeTime);
sendReply(client, bundle);
bitmap.recycle();
} catch (Exception e) {

Powered by Google App Engine
This is Rietveld 408576698