Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(102)

Side by Side Diff: tools/testing/dart/runtime_configuration.dart

Issue 2915843003: Simplify test_suite.dart. (Closed)
Patch Set: Fix path in test. Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « tools/testing/dart/package_testing_support.dart ('k') | tools/testing/dart/test_progress.dart » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2014, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2014, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 import 'dart:io'; 5 import 'dart:io';
6 6
7 import 'compiler_configuration.dart'; 7 import 'compiler_configuration.dart';
8 import 'configuration.dart'; 8 import 'configuration.dart';
9 // TODO(ahe): Remove this import, we can precompute all the values required 9 // TODO(ahe): Remove this import, we can precompute all the values required
10 // from TestSuite once the refactoring is complete. 10 // from TestSuite once the refactoring is complete.
11 import 'test_suite.dart'; 11 import 'test_suite.dart';
12 import 'test_runner.dart'; 12 import 'test_runner.dart';
13 import 'utils.dart';
13 14
14 /// Describes the commands to run a given test case or its compiled output. 15 /// Describes the commands to run a given test case or its compiled output.
15 /// 16 ///
16 /// A single runtime configuration object exists per test suite, and is thus 17 /// A single runtime configuration object exists per test suite, and is thus
17 /// shared between multiple test cases, it should not be mutated after 18 /// shared between multiple test cases, it should not be mutated after
18 /// construction. 19 /// construction.
19 abstract class RuntimeConfiguration { 20 abstract class RuntimeConfiguration {
20 factory RuntimeConfiguration(Configuration configuration) { 21 factory RuntimeConfiguration(Configuration configuration) {
21 switch (configuration.runtime) { 22 switch (configuration.runtime) {
22 case Runtime.contentShellOnAndroid: 23 case Runtime.contentShellOnAndroid:
(...skipping 336 matching lines...) Expand 10 before | Expand all | Expand 10 after
359 class DummyRuntimeConfiguration extends DartVmRuntimeConfiguration { 360 class DummyRuntimeConfiguration extends DartVmRuntimeConfiguration {
360 List<Command> computeRuntimeCommands( 361 List<Command> computeRuntimeCommands(
361 TestSuite suite, 362 TestSuite suite,
362 CommandBuilder commandBuilder, 363 CommandBuilder commandBuilder,
363 CommandArtifact artifact, 364 CommandArtifact artifact,
364 List<String> arguments, 365 List<String> arguments,
365 Map<String, String> environmentOverrides) { 366 Map<String, String> environmentOverrides) {
366 throw "Unimplemented runtime '$runtimeType'"; 367 throw "Unimplemented runtime '$runtimeType'";
367 } 368 }
368 } 369 }
OLDNEW
« no previous file with comments | « tools/testing/dart/package_testing_support.dart ('k') | tools/testing/dart/test_progress.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698