Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(248)

Issue 291583005: Change FilterChain::Append() to a template method. (Closed)

Created:
6 years, 7 months ago by yzshen1
Modified:
6 years, 7 months ago
CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org
Visibility:
Public.

Description

Change FilterChain::Append() to a template method. So that we can avoid creating PassThroughFilter. The CL also makes FilterChain::GetHead() a little more efficient (SyncDispatcher calls it once for receiving each message). BUG=None TEST=None R=darin@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=271107

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+33 lines, -35 lines) Patch
M mojo/public/cpp/bindings/lib/filter_chain.h View 3 chunks +16 lines, -9 lines 0 comments Download
M mojo/public/cpp/bindings/lib/filter_chain.cc View 2 chunks +7 lines, -16 lines 0 comments Download
M mojo/public/cpp/bindings/lib/interface_impl_internal.h View 1 chunk +3 lines, -3 lines 0 comments Download
M mojo/public/cpp/bindings/lib/interface_ptr_internal.h View 1 chunk +3 lines, -3 lines 0 comments Download
M mojo/public/cpp/bindings/lib/router.cc View 1 chunk +1 line, -1 line 0 comments Download
M mojo/public/cpp/bindings/sync_dispatcher.h View 1 chunk +3 lines, -3 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
yzshen1
Hi, Darin. Would you please take a look? Thanks!
6 years, 7 months ago (2014-05-16 09:05:22 UTC) #1
darin (slow to review)
LGTM
6 years, 7 months ago (2014-05-16 18:19:06 UTC) #2
yzshen1
The CQ bit was checked by yzshen@chromium.org
6 years, 7 months ago (2014-05-16 18:45:15 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/yzshen@chromium.org/291583005/1
6 years, 7 months ago (2014-05-16 18:46:23 UTC) #4
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). Please consider checking whether the failures are ...
6 years, 7 months ago (2014-05-16 19:20:01 UTC) #5
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 7 months ago (2014-05-16 19:44:33 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: android_dbg_triggered_tests on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/android_dbg_triggered_tests/builds/154603)
6 years, 7 months ago (2014-05-16 19:44:33 UTC) #7
yzshen1
6 years, 7 months ago (2014-05-16 21:53:10 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 manually as r271107 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698