Fix minor presentation issues in RTL languages.

Fix minor presentation issues in RTL languages.

This fixes (1) and (4) in the issue 371232.
- Set correct margin for the title 'Files' app.
- Correct separator's direction. 

BUG=371232
TEST=manually confirmed

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=271360

[fukino, 2014-05-16 08:59:46]

hirono san, PTAL!

[hirono, 2014-05-16 09:11:46]

Thank you!

https://codereview.chromium.org/291583004/diff/1/ui/file_manager/file_manager...
File ui/file_manager/file_manager/foreground/css/file_manager.css (right):

https://codereview.chromium.org/291583004/diff/1/ui/file_manager/file_manager...
ui/file_manager/file_manager/foreground/css/file_manager.css:170: margin-left:
15px;
nit: According to our style guide:
https://google-styleguide.googlecode.com/svn/trunk/htmlcssguide.xml?showone=S...,
shorthand properties are preferred if we can use them.

[fukino, 2014-05-16 09:22:30]

Oops, I read the item in StyleGuide this week, but I failed to remenber...
Thanks!

https://codereview.chromium.org/291583004/diff/1/ui/file_manager/file_manager...
File ui/file_manager/file_manager/foreground/css/file_manager.css (right):

https://codereview.chromium.org/291583004/diff/1/ui/file_manager/file_manager...
ui/file_manager/file_manager/foreground/css/file_manager.css:170: margin-left:
15px;
On 2014/05/16 09:11:47, hirono wrote:
> nit: According to our style guide:
>
https://google-styleguide.googlecode.com/svn/trunk/htmlcssguide.xml?showone=S...,
> shorthand properties are preferred if we can use them.

Done.

[hirono, 2014-05-19 04:27:16]

https://codereview.chromium.org/291583004/diff/10001/ui/file_manager/file_man...
File ui/file_manager/file_manager/foreground/css/file_manager.css (right):

https://codereview.chromium.org/291583004/diff/10001/ui/file_manager/file_man...
ui/file_manager/file_manager/foreground/css/file_manager.css:626:
-webkit-transform: rotate(180deg);
nit: Maybe scaleX(-1) is better in case that the asset is changed as it is not
horizontal symmetry.

[fukino, 2014-05-19 05:11:06]

https://codereview.chromium.org/291583004/diff/10001/ui/file_manager/file_man...
File ui/file_manager/file_manager/foreground/css/file_manager.css (right):

https://codereview.chromium.org/291583004/diff/10001/ui/file_manager/file_man...
ui/file_manager/file_manager/foreground/css/file_manager.css:626:
-webkit-transform: rotate(180deg);
On 2014/05/19 04:27:16, hirono wrote:
> nit: Maybe scaleX(-1) is better in case that the asset is changed as it is not
> horizontal symmetry.

Done.
scaleX is exactly what I need. Thanks!!

[hirono, 2014-05-19 05:16:52]

On 2014/05/19 05:11:06, fukino wrote:
>
https://codereview.chromium.org/291583004/diff/10001/ui/file_manager/file_man...
> File ui/file_manager/file_manager/foreground/css/file_manager.css (right):
> 
>
https://codereview.chromium.org/291583004/diff/10001/ui/file_manager/file_man...
> ui/file_manager/file_manager/foreground/css/file_manager.css:626:
> -webkit-transform: rotate(180deg);
> On 2014/05/19 04:27:16, hirono wrote:
> > nit: Maybe scaleX(-1) is better in case that the asset is changed as it is
not
> > horizontal symmetry.
> 
> Done.
> scaleX is exactly what I need. Thanks!!

lgtm!

[fukino, 2014-05-19 05:17:53]

The CQ bit was checked by fukino@chromium.org

[commit-bot: I haz the power, 2014-05-19 05:18:01]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/fukino@chromium.org/291583004/30001

[commit-bot: I haz the power, 2014-05-19 07:08:01]

FYI, CQ is re-trying this CL (attempt #1).
Please consider checking whether the failures are real,
and report flakes to chrome-troopers@google.com.
The failing builders are:
  android_dbg_triggered_tests on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/android_dbg_triggered...)

[commit-bot: I haz the power, 2014-05-19 08:21:12]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-05-19 08:21:13]

Try jobs failed on following builders:
  android_dbg_triggered_tests on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/android_dbg_triggered...)

[fukino, 2014-05-19 10:17:55]

The CQ bit was checked by fukino@chromium.org

[commit-bot: I haz the power, 2014-05-19 10:18:18]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/fukino@chromium.org/291583004/30001

[commit-bot: I haz the power, 2014-05-19 10:24:55]

Change committed as 271360

[amryouseff_gmail.com, 2014-09-02 12:40:23]

I wanna to fix my web Css
http://www.justiceed.ca/

بتاريخ الجمعة، 16 مايو، 2014 UTC+3 11:59:46 ص، كتب fuk...@chromium.org:
>
> Reviewers: hirono, 
>
> Message: 
> hirono san, PTAL! 
>
> Description: 
> Fix minor presentation issues in RTL languages. 
>
> This fixes (1) and (4) in the issue 371232. 
> - Set correct margin for the title 'Files' app. 
> - Correct separator's direction. 
>
> BUG=371232 
> TEST=manually confirmed 
>
> Please review this at https://codereview.chromium.org/291583004/  
>
> SVN Base: svn://svn.chromium.org/chrome/trunk/src  
>
> Affected files (+8, -2 lines): 
>    M ui/file_manager/file_manager/foreground/css/file_manager.css 
>
>
> Index: ui/file_manager/file_manager/foreground/css/file_manager.css 
> diff --git a/ui/file_manager/file_manager/foreground/css/file_manager.css 
>   
> b/ui/file_manager/file_manager/foreground/css/file_manager.css 
> index   
>
068214898bd4d16b163e96a444a84100d82ccdea..f397c6838d703529f24d9292bcba607368317670

>   
> 100644 
> --- a/ui/file_manager/file_manager/foreground/css/file_manager.css 
> +++ b/ui/file_manager/file_manager/foreground/css/file_manager.css 
> @@ -165,13 +165,15 @@ a:focus { 
>   } 
>
>   .dialog-navigation-list-header #app-name { 
> -  -webkit-margin-start: 15px; 
>     color: #303030; 
>     font-size: 130%; 
> +  margin-left: 15px; 
> +  margin-right: 15px; 
>   } 
>
>   .dialog-navigation-list-header #profile-badge:not([hidden]) + #app-name 
> { 
> -  -webkit-margin-start: 0; 
> +  margin-left: 0; 
> +  margin-right: 0; 
>   } 
>
>   .dialog-navigation-list-contents { 
> @@ -622,6 +624,10 @@   
> body[drive] .dialog-container[connection='metered'] .offline-icon-space { 
>     width: 25px; 
>   } 
>
> +html[dir='rtl'] .breadcrumbs .separator { 
> +  -webkit-transform: rotate(180deg); 
> +} 
> + 
>   #filename-input-box input { 
>     border: 1px solid #c8c8c8; 
>     border-radius: 1px; 
>
>
>

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.