Issue 291583003: Revert of Fix X11TopmostWindowFinder

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 291583003: Revert of Fix X11TopmostWindowFinder (Closed)

Created:
6 years, 7 months ago by Adrian Kuegel

Modified:
6 years, 7 months ago

Reviewers:
pkotwicz, sadrul

CC:
chromium-reviews, tfarina, ben+views_chromium.org, tdanderson+views_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Revert of Fix X11TopmostWindowFinder (https://codereview.chromium.org/268673017/) Reason for revert: Speculative revert because of failure in desktop_screen_x11_unittest.cc (DesktopScreenX11Test.GetWindowAtScreenPoint). Original issue's description: > Fix X11TopmostWindowFinder to take into account > - Window manager provided window borders > - Custom shapes specified via views::Widget::SetShape() > > BUG=None > TEST=None > > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=270877 TBR=sadrul@chromium.org,pkotwicz@chromium.org NOTREECHECKS=true NOTRY=true BUG=None Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=270964

Patch Set 1 #

Created: 6 years, 7 months ago

(Patch set is too large to download)

	Unified diffs	Side-by-side diffs	Stats (+72 lines, -497 lines)			Patch
M	ui/base/x/x11_util.h	View	1 chunk	+0 lines, -3 lines	0 comments	Download
M	ui/base/x/x11_util.cc	View	3 chunks	+9 lines, -8 lines	0 comments	Download
M	ui/views/views.gyp	View	2 chunks	+0 lines, -7 lines	0 comments	Download
M	ui/views/widget/desktop_aura/desktop_window_tree_host_x11.h	View	4 chunks	+2 lines, -23 lines	0 comments	Download
M	ui/views/widget/desktop_aura/desktop_window_tree_host_x11.cc	View	10 chunks	+58 lines, -96 lines	0 comments	Download
D	ui/views/widget/desktop_aura/desktop_window_tree_host_x11_unittest.cc	View	1 chunk	+0 lines, -338 lines	0 comments	Download
M	ui/views/widget/desktop_aura/x11_topmost_window_finder.cc	View	3 chunks	+3 lines, -22 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/akuegel@chromium.org/291583003/1

6 years, 7 months ago (2014-05-16 08:23:53 UTC) #2

Adrian Kuegel

6 years, 7 months ago (2014-05-16 09:04:20 UTC) #4

Message was sent while issue was closed.

On 2014/05/16 08:23:09, Adrian Kuegel wrote:
> Created Revert of Fix X11TopmostWindowFinder

Seems it was the right CL to revert, the test passes again.

Expand Messages | Collapse Messages