Files.app: Force to update the gear menu position when the menu opens.

Files.app: Force to update the gear menu position when the menu opens.

After maximizing/restoring the app widnow, the position of gear menu may not be
updated due to crbug.com/374093. This CL adds a workaround for the bug, which
forces to update the gear menu position.

BUG=372380
TEST=manually
R=fukino@chromium.org, yoshiki@chromium.org

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=270963

[hirono, 2014-05-16 05:35:27]

PTAL the CL? Thank you!

[fukino, 2014-05-16 06:16:29]

lgtm with nits.
The causing bug might be related to the --webkit-margin-start issue, too...

https://codereview.chromium.org/291583002/diff/1/ui/file_manager/file_manager...
File ui/file_manager/file_manager/foreground/js/file_manager.js (right):

https://codereview.chromium.org/291583002/diff/1/ui/file_manager/file_manager...
ui/file_manager/file_manager/foreground/js/file_manager.js:1355:
console.log('resize');
remains unintentionally?

[hirono, 2014-05-16 06:19:27]

Thank you!
@yoshiki - PTAL the CL?

https://codereview.chromium.org/291583002/diff/1/ui/file_manager/file_manager...
File ui/file_manager/file_manager/foreground/js/file_manager.js (right):

https://codereview.chromium.org/291583002/diff/1/ui/file_manager/file_manager...
ui/file_manager/file_manager/foreground/js/file_manager.js:1355:
console.log('resize');
On 2014/05/16 06:16:29, fukino wrote:
> remains unintentionally?

Oops, removed.

[yoshiki, 2014-05-16 06:24:01]

lgtm with nit

https://codereview.chromium.org/291583002/diff/20001/ui/file_manager/file_man...
File ui/file_manager/file_manager/foreground/js/file_manager.js (right):

https://codereview.chromium.org/291583002/diff/20001/ui/file_manager/file_man...
ui/file_manager/file_manager/foreground/js/file_manager.js:537: // TODO(hirono):
Remove the workaround for the crbug.com/374093 after fixing
nit: Please add a brief comment of the behavior, since the code itself is
unclear.

eg. "Force to update the gear menu position"

[hirono, 2014-05-16 06:49:56]

Thank you!

https://codereview.chromium.org/291583002/diff/20001/ui/file_manager/file_man...
File ui/file_manager/file_manager/foreground/js/file_manager.js (right):

https://codereview.chromium.org/291583002/diff/20001/ui/file_manager/file_man...
ui/file_manager/file_manager/foreground/js/file_manager.js:537: // TODO(hirono):
Remove the workaround for the crbug.com/374093 after fixing
On 2014/05/16 06:24:01, yoshiki wrote:
> nit: Please add a brief comment of the behavior, since the code itself is
> unclear.
> 
> eg. "Force to update the gear menu position"

Yes, we need it. Done!

[hirono, 2014-05-16 06:50:00]

The CQ bit was checked by hirono@chromium.org

[commit-bot: I haz the power, 2014-05-16 06:50:38]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/hirono@chromium.org/291583002/40001

[hirono, 2014-05-16 08:09:21]

Committed patchset #3 manually as r270963 (presubmit successful).