extensions/renderer/resources/context_menus_handlers.js - Issue 2915813003: [Extensions Bindings] Accept null callbacks while ignoring schema

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: extensions/renderer/resources/context_menus_handlers.js

Issue 2915813003: [Extensions Bindings] Accept null callbacks while ignoring schema (Closed)

Patch Set: jbroman's Created 3 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: extensions/renderer/resources/context_menus_handlers.js

diff --git a/extensions/renderer/resources/context_menus_handlers.js b/extensions/renderer/resources/context_menus_handlers.js

index eed54796238c433c735d86581f8cf7cf019df891..0e718c4f5acbc8d1873ed85f1b2a495dc932c798 100644

--- a/extensions/renderer/resources/context_menus_handlers.js

+++ b/extensions/renderer/resources/context_menus_handlers.js

@@ -187,7 +187,7 @@ function createContextMenusHandlers(isWebview) {

'chromeWebViewInternal.contextMenusRemoveAll' :

'contextMenus.removeAll';

sendRequest(name, $Array.from(arguments),

- this.definition.parameters, optArgs);

+ bindingUtil ? undefined : this.definition.parameters, optArgs);

};

return {

« no previous file with comments | « extensions/renderer/api_signature_unittest.cc ('k') | no next file » | no next file with comments »