Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(15)

Side by Side Diff: content/browser/frame_host/render_frame_host_impl.cc

Issue 2915813002: Add missing return statement after ReceivedBadMessage call. (Closed)
Patch Set: review comment Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « content/browser/browser_side_navigation_browsertest.cc ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "content/browser/frame_host/render_frame_host_impl.h" 5 #include "content/browser/frame_host/render_frame_host_impl.h"
6 6
7 #include <algorithm> 7 #include <algorithm>
8 #include <utility> 8 #include <utility>
9 9
10 #include "base/bind.h" 10 #include "base/bind.h"
(...skipping 2185 matching lines...) Expand 10 before | Expand all | Expand 10 after
2196 TRACE_EVENT2("navigation", "RenderFrameHostImpl::OnBeginNavigation", 2196 TRACE_EVENT2("navigation", "RenderFrameHostImpl::OnBeginNavigation",
2197 "frame_tree_node", frame_tree_node_->frame_tree_node_id(), "url", 2197 "frame_tree_node", frame_tree_node_->frame_tree_node_id(), "url",
2198 common_params.url.possibly_invalid_spec()); 2198 common_params.url.possibly_invalid_spec());
2199 2199
2200 CommonNavigationParams validated_params = common_params; 2200 CommonNavigationParams validated_params = common_params;
2201 GetProcess()->FilterURL(false, &validated_params.url); 2201 GetProcess()->FilterURL(false, &validated_params.url);
2202 if (!validated_params.base_url_for_data_url.is_empty()) { 2202 if (!validated_params.base_url_for_data_url.is_empty()) {
2203 // Kills the process. http://crbug.com/726142 2203 // Kills the process. http://crbug.com/726142
2204 bad_message::ReceivedBadMessage( 2204 bad_message::ReceivedBadMessage(
2205 GetProcess(), bad_message::RFH_BASE_URL_FOR_DATA_URL_SPECIFIED); 2205 GetProcess(), bad_message::RFH_BASE_URL_FOR_DATA_URL_SPECIFIED);
2206 return;
2206 } 2207 }
2207 2208
2208 BeginNavigationParams validated_begin_params = begin_params; 2209 BeginNavigationParams validated_begin_params = begin_params;
2209 GetProcess()->FilterURL(true, &validated_begin_params.searchable_form_url); 2210 GetProcess()->FilterURL(true, &validated_begin_params.searchable_form_url);
2210 2211
2211 if (!ChildProcessSecurityPolicyImpl::GetInstance()->CanReadRequestBody( 2212 if (!ChildProcessSecurityPolicyImpl::GetInstance()->CanReadRequestBody(
2212 GetSiteInstance(), validated_params.post_data)) { 2213 GetSiteInstance(), validated_params.post_data)) {
2213 bad_message::ReceivedBadMessage(GetProcess(), 2214 bad_message::ReceivedBadMessage(GetProcess(),
2214 bad_message::RFH_ILLEGAL_UPLOAD_PARAMS); 2215 bad_message::RFH_ILLEGAL_UPLOAD_PARAMS);
2215 return; 2216 return;
(...skipping 1849 matching lines...) Expand 10 before | Expand all | Expand 10 after
4065 } 4066 }
4066 4067
4067 void RenderFrameHostImpl::ForwardGetInterfaceToRenderFrame( 4068 void RenderFrameHostImpl::ForwardGetInterfaceToRenderFrame(
4068 const std::string& interface_name, 4069 const std::string& interface_name,
4069 mojo::ScopedMessagePipeHandle pipe) { 4070 mojo::ScopedMessagePipeHandle pipe) {
4070 GetRemoteInterfaces()->GetInterface(interface_name, std::move(pipe)); 4071 GetRemoteInterfaces()->GetInterface(interface_name, std::move(pipe));
4071 } 4072 }
4072 #endif 4073 #endif
4073 4074
4074 } // namespace content 4075 } // namespace content
OLDNEW
« no previous file with comments | « content/browser/browser_side_navigation_browsertest.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698