Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(487)

Issue 2915763008: Perform type inference on default values of optional/named parameters. (Closed)

Created:
3 years, 6 months ago by Paul Berry
Modified:
3 years, 6 months ago
Reviewers:
ahe, scheglov
CC:
reviews_dartlang.org, dart-fe-team+reviews_google.com
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Perform type inference on default values of optional/named parameters. R=ahe@google.com Committed: https://github.com/dart-lang/sdk/commit/eefdf15aa1bb798dc70c77368511d82fd2151d33

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+187 lines, -1 line) Patch
M pkg/front_end/lib/src/fasta/kernel/body_builder.dart View 1 chunk +2 lines, -0 lines 0 comments Download
M pkg/front_end/lib/src/fasta/kernel/kernel_shadow_ast.dart View 2 chunks +25 lines, -1 line 0 comments Download
M pkg/front_end/lib/src/fasta/type_inference/type_inferrer.dart View 2 chunks +11 lines, -0 lines 0 comments Download
M pkg/front_end/test/fasta/kompile.status View 1 chunk +2 lines, -0 lines 0 comments Download
A pkg/front_end/testcases/inference/parameter_defaults_downwards.dart View 1 chunk +19 lines, -0 lines 0 comments Download
A pkg/front_end/testcases/inference/parameter_defaults_downwards.dart.direct.expect View 1 chunk +12 lines, -0 lines 0 comments Download
A pkg/front_end/testcases/inference/parameter_defaults_downwards.dart.outline.expect View 1 chunk +10 lines, -0 lines 0 comments Download
A pkg/front_end/testcases/inference/parameter_defaults_downwards.dart.strong.expect View 1 chunk +12 lines, -0 lines 0 comments Download
A pkg/front_end/testcases/inference/parameter_defaults_upwards.dart View 1 chunk +34 lines, -0 lines 0 comments Download
A pkg/front_end/testcases/inference/parameter_defaults_upwards.dart.direct.expect View 1 chunk +22 lines, -0 lines 0 comments Download
A pkg/front_end/testcases/inference/parameter_defaults_upwards.dart.outline.expect View 1 chunk +16 lines, -0 lines 0 comments Download
A pkg/front_end/testcases/inference/parameter_defaults_upwards.dart.strong.expect View 1 chunk +22 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
Paul Berry
3 years, 6 months ago (2017-06-02 04:06:18 UTC) #2
ahe
lgtm
3 years, 6 months ago (2017-06-02 04:11:43 UTC) #3
Paul Berry
Committed patchset #1 (id:1) manually as eefdf15aa1bb798dc70c77368511d82fd2151d33 (presubmit successful).
3 years, 6 months ago (2017-06-02 04:18:43 UTC) #5
scheglov
3 years, 6 months ago (2017-06-02 04:21:43 UTC) #6
Message was sent while issue was closed.
LGTM

Powered by Google App Engine
This is Rietveld 408576698