Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(15)

Unified Diff: components/sync/model_impl/processor_entity_tracker.h

Issue 2915763005: [Sync] Implement support for updating storage key for new entities (Closed)
Patch Set: Rebase. Fix recommit for encryption scenario. Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/sync/model_impl/processor_entity_tracker.h
diff --git a/components/sync/model_impl/processor_entity_tracker.h b/components/sync/model_impl/processor_entity_tracker.h
index 8f262f367d67de1c4ea1eee1a8b64dcd5f4961f3..7b76f094d98c24ea5693951d52735f1a6e787832 100644
--- a/components/sync/model_impl/processor_entity_tracker.h
+++ b/components/sync/model_impl/processor_entity_tracker.h
@@ -100,11 +100,10 @@ class ProcessorEntityTracker {
// Clears any in-memory sync state associated with outstanding commits.
void ClearTransientSyncState();
- // Update storage_key_.
- // This function should only be called by
- // ModelTypeChangeProcessor::UpdateStorageKey for the data type which does not
- // create storage key based on syncer::EntityData.
- void SetStorageKey(const std::string& new_key);
+ // Update storage_key_. Allows setting storage key for datatypes that don't
+ // generate storage key from syncer::EntityData. Should only be called for
+ // tracker initialized with empty storage key.
+ void SetStorageKey(const std::string& storage_key);
// Takes the passed commit data updates its fields with values from metadata
// and caches it in the instance. The data is swapped from the input struct
« no previous file with comments | « components/sync/model/model_type_sync_bridge.cc ('k') | components/sync/model_impl/processor_entity_tracker.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698