[Sync] Implement support for updating storage key for new entities

components/sync/model_impl/processor_entity_tracker_unittest.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "components/sync/model_impl/processor_entity_tracker.h"
 
 #include <utility>
 
 #include "base/memory/ptr_util.h"
 #include "components/sync/base/model_type.h"
@@ skipping 89 matching lines @@
 // properly intialized and flags properly set.  Anything more complicated would
 // be a redundant and incomplete version of the SharedModelTypeProcessor tests.
 class ProcessorEntityTrackerTest : public ::testing::Test {
  public:
   ProcessorEntityTrackerTest()
       : ctime_(base::Time::Now() - base::TimeDelta::FromSeconds(1)) {}
 
   std::unique_ptr<ProcessorEntityTracker> CreateNew() {
     return ProcessorEntityTracker::CreateNew(kKey, kHash, "", ctime_);
   }
+  std::unique_ptr<ProcessorEntityTracker> CreateNewWithEmptyStorageKey() {
+    return ProcessorEntityTracker::CreateNew("", kHash, "", ctime_);
+  }
 
   std::unique_ptr<ProcessorEntityTracker> CreateSynced() {
     std::unique_ptr<ProcessorEntityTracker> entity = CreateNew();
     entity->RecordAcceptedUpdate(
         GenerateUpdate(*entity, kHash, kId, kName, kValue1, ctime_, 1));
     DCHECK(!entity->IsUnsynced());
     return entity;
   }
 
   const base::Time ctime_;
@@ skipping 115 matching lines @@
   EXPECT_FALSE(entity->IsUnsynced());
   EXPECT_FALSE(entity->RequiresCommitRequest());
   EXPECT_FALSE(entity->RequiresCommitData());
   EXPECT_FALSE(entity->CanClearMetadata());
   EXPECT_TRUE(entity->UpdateIsReflection(9));
   EXPECT_TRUE(entity->UpdateIsReflection(10));
   EXPECT_FALSE(entity->UpdateIsReflection(11));
   EXPECT_FALSE(entity->HasCommitData());
 }
 
+// Test creating tracker for new server item with empty storage key, applying
+// update and updating storage key.
+TEST_F(ProcessorEntityTrackerTest, NewServerItem_EmptyStorageKey) {
+  std::unique_ptr<ProcessorEntityTracker> entity =
+      CreateNewWithEmptyStorageKey();
+
+  EXPECT_EQ("", entity->storage_key());
+
+  const base::Time mtime = base::Time::Now();
+  entity->RecordAcceptedUpdate(
+      GenerateUpdate(*entity, kHash, kId, kName, kValue1, mtime, 10));
+  entity->SetStorageKey(kKey);
+  EXPECT_EQ(kKey, entity->storage_key());
+}
+
 // Test state for a tombstone received for a previously unknown item.
 TEST_F(ProcessorEntityTrackerTest, NewServerTombstone) {
   std::unique_ptr<ProcessorEntityTracker> entity = CreateNew();
 
   const base::Time mtime = base::Time::Now();
   entity->RecordAcceptedUpdate(
       GenerateTombstone(*entity, kHash, kId, kName, mtime, 1));
 
   EXPECT_EQ(kId, entity->metadata().server_id());
   EXPECT_TRUE(entity->metadata().is_deleted());
@@ skipping 219 matching lines @@
   EXPECT_EQ("", entity->metadata().base_specifics_hash());
 
   EXPECT_FALSE(entity->IsUnsynced());
   EXPECT_FALSE(entity->RequiresCommitRequest());
   EXPECT_FALSE(entity->RequiresCommitData());
   EXPECT_FALSE(entity->CanClearMetadata());
   EXPECT_FALSE(entity->HasCommitData());
 }
 
 }  // namespace syncer