components/password_manager/core/browser/stub_password_manager_client.cc - Issue 2915763003: [Password Manager] Show omnibox icon and anchored prompt once user start typing password

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/password_manager/core/browser/stub_password_manager_client.cc

Issue 2915763003: [Password Manager] Show omnibox icon and anchored prompt once user start typing password (Closed)

Patch Set: '|web_contents|' comment is back Created 3 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/password_manager/password_manager_test_base.cc ('K') | « components/password_manager/core/browser/stub_password_manager_client.h ('k') | ios/chrome/browser/passwords/ios_chrome_password_manager_client.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/password_manager/core/browser/stub_password_manager_client.cc

diff --git a/components/password_manager/core/browser/stub_password_manager_client.cc b/components/password_manager/core/browser/stub_password_manager_client.cc

index 14a3cbba52e743294f907647db40eb2b77cafb98..d9c451a757003eae67862dc4e98b8b40408c409e 100644

--- a/components/password_manager/core/browser/stub_password_manager_client.cc

+++ b/components/password_manager/core/browser/stub_password_manager_client.cc

@@ -24,6 +24,13 @@ bool StubPasswordManagerClient::PromptUserToSaveOrUpdatePassword(

return false;

}

+void StubPasswordManagerClient::ShowManualFallbackForSaving(

+ std::unique_ptr<PasswordFormManager> form_to_save,

+ bool has_generated_password,

+ bool update_password) {}

+void StubPasswordManagerClient::HideManualFallbackForSaving() {}

bool StubPasswordManagerClient::PromptUserToChooseCredentials(

std::vector<std::unique_ptr<autofill::PasswordForm>> local_forms,

const GURL& origin,