Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(127)

Unified Diff: third_party/WebKit/Source/core/input/KeyboardEventManager.cpp

Issue 2915763003: [Password Manager] Show omnibox icon and anchored prompt once user start typing password (Closed)
Patch Set: Sent For Review Created 3 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/input/KeyboardEventManager.cpp
diff --git a/third_party/WebKit/Source/core/input/KeyboardEventManager.cpp b/third_party/WebKit/Source/core/input/KeyboardEventManager.cpp
index 4d7e534d2c2e22fd97e0e4572c07f1a7345955d8..0cf8e9510f3debc3f88147fa88143b4f21c2f748 100644
--- a/third_party/WebKit/Source/core/input/KeyboardEventManager.cpp
+++ b/third_party/WebKit/Source/core/input/KeyboardEventManager.cpp
@@ -199,7 +199,8 @@ WebInputEventResult KeyboardEventManager::KeyEvent(
bool is_browser_shortcut = initial_key_event.is_browser_shortcut;
std::unique_ptr<UserGestureIndicator> gesture_indicator;
- if (!is_modifier && !is_browser_shortcut) {
+ if (!is_modifier &&
+ (!is_browser_shortcut || initial_key_event.text[0] == '\b')) {
vasilii 2017/07/21 12:48:21 Can you clarify this?
kolos1 2017/07/24 15:33:31 Please ignore changes in this file. It is a quick
gesture_indicator.reset(new UserGestureIndicator(
UserGestureToken::Create(frame_->GetDocument())));
}

Powered by Google App Engine
This is Rietveld 408576698