Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(364)

Unified Diff: components/password_manager/core/browser/password_manager_driver.h

Issue 2915763003: [Password Manager] Show omnibox icon and anchored prompt once user start typing password (Closed)
Patch Set: Sent For Review Created 3 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/password_manager/core/browser/password_manager_driver.h
diff --git a/components/password_manager/core/browser/password_manager_driver.h b/components/password_manager/core/browser/password_manager_driver.h
index af6551c4256a91ba8e5a5a6700bea56ffd7660b5..7470147f2acafcdd2f4af7cde7dbdb875caaea09 100644
--- a/components/password_manager/core/browser/password_manager_driver.h
+++ b/components/password_manager/core/browser/password_manager_driver.h
@@ -78,6 +78,13 @@ class PasswordManagerDriver
// the corresponding password form, so that it can be saved.
virtual void ForceSavePassword() {}
+ // Tells the driver to show the manual fallback for password saving, i.e. to
vasilii 2017/07/21 12:48:21 Who tells whom? I think PasswordManagerDriver does
kolos1 2017/07/24 15:33:30 "Tells the driver..." is pattern for comments for
+ // show the omnibox icon with anchored hidden save prompt.
+ virtual void ShowManualFallback(const autofill::PasswordForm& form) {}
+
+ // Tells the driver to hide the manual fallback for saving.
+ virtual void HideManualFallback() {}
+
// Tells the driver to find the focused password field and to show generation
// popup at it.
virtual void GeneratePassword() {}

Powered by Google App Engine
This is Rietveld 408576698