Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5621)

Unified Diff: chrome/renderer/autofill/fake_content_password_manager_driver.h

Issue 2915763003: [Password Manager] Show omnibox icon and anchored prompt once user start typing password (Closed)
Patch Set: Sent For Review Created 3 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/renderer/autofill/fake_content_password_manager_driver.h
diff --git a/chrome/renderer/autofill/fake_content_password_manager_driver.h b/chrome/renderer/autofill/fake_content_password_manager_driver.h
index 5de449187b142b591739aa7b4ac70f5c42da3fef..f0f8d596953a11b004321565e299f82df4d801e4 100644
--- a/chrome/renderer/autofill/fake_content_password_manager_driver.h
+++ b/chrome/renderer/autofill/fake_content_password_manager_driver.h
@@ -130,6 +130,10 @@ class FakeContentPasswordManagerDriver
return called_check_safe_browsing_reputation_cnt_;
}
+ int called_show_manual_fallback_cnt() {
vasilii 2017/07/21 12:48:20 const
kolos1 2017/07/24 15:33:30 Done.
+ return called_show_manual_fallback_cnt_;
+ }
+
private:
// mojom::PasswordManagerDriver:
void PasswordFormsParsed(
@@ -170,6 +174,9 @@ class FakeContentPasswordManagerDriver
void CheckSafeBrowsingReputation(const GURL& form_action,
const GURL& frame_url) override;
+ void ShowManualFallback(const autofill::PasswordForm& password_form) override;
+ void HideManualFallback() override;
+
// Records whether ShowPasswordSuggestions() gets called.
bool called_show_pw_suggestions_ = false;
// Records data received via ShowPasswordSuggestions() call.
@@ -210,6 +217,10 @@ class FakeContentPasswordManagerDriver
// Records number of times CheckSafeBrowsingReputation() gets called.
int called_check_safe_browsing_reputation_cnt_ = 0;
+ // Records the number of request to show manual fallback for password saving.
+ // If it is zero, the fallback is not available.
+ int called_show_manual_fallback_cnt_ = 0;
vasilii 2017/07/21 12:48:20 What is "cnt"? Probably should be renamed to "coun
kolos1 2017/07/24 15:33:30 Done.
+
mojo::BindingSet<autofill::mojom::PasswordManagerDriver> bindings_;
};

Powered by Google App Engine
This is Rietveld 408576698