Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1004)

Unified Diff: chrome/browser/ui/passwords/passwords_client_ui_delegate.h

Issue 2915763003: [Password Manager] Show omnibox icon and anchored prompt once user start typing password (Closed)
Patch Set: Sent For Review Created 3 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/passwords/passwords_client_ui_delegate.h
diff --git a/chrome/browser/ui/passwords/passwords_client_ui_delegate.h b/chrome/browser/ui/passwords/passwords_client_ui_delegate.h
index b2b5928a8c88f272fe721ce341004f897a2e9963..e88918aa0286ef461c65f5504070b6653c2f1dcc 100644
--- a/chrome/browser/ui/passwords/passwords_client_ui_delegate.h
+++ b/chrome/browser/ui/passwords/passwords_client_ui_delegate.h
@@ -38,6 +38,16 @@ class PasswordsClientUIDelegate {
virtual void OnUpdatePasswordSubmitted(
std::unique_ptr<password_manager::PasswordFormManager> form_manager) = 0;
+ // Called when the user starts typing in a password field. This creates a
+ // save/update prompt anchored to the omnibox icon but keeps it hidden.
vasilii 2017/07/21 12:48:20 It doesn't create any prompt. Only the icon.
kolos1 2017/07/24 15:33:30 Done.
+ virtual void OnShowManualFallback(
vasilii 2017/07/21 12:48:20 ForSaving
kolos1 2017/07/24 15:33:30 Done.
+ std::unique_ptr<password_manager::PasswordFormManager> form_manager,
+ bool is_update) = 0;
+
+ // Called when the user cleared the password field. This removes the hidden
+ // save/update prompt and switch UI to |MANAGE_STATE|.
vasilii 2017/07/21 12:48:20 There is no a hidden prompt at any point in time.
kolos1 2017/07/24 15:33:30 Done.
+ virtual void OnHideManualFallback() = 0;
+
// Called when the site asks user to choose from credentials. This triggers
// the UI to prompt the user. |local_credentials| shouldn't be empty. |origin|
// is a URL of the site that requested a credential.

Powered by Google App Engine
This is Rietveld 408576698