Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(255)

Unified Diff: chrome/browser/password_manager/password_manager_interactive_uitest.cc

Issue 2915763003: [Password Manager] Show omnibox icon and anchored prompt once user start typing password (Closed)
Patch Set: Rebase Created 3 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/password_manager/password_manager_interactive_uitest.cc
diff --git a/chrome/browser/password_manager/password_manager_interactive_uitest.cc b/chrome/browser/password_manager/password_manager_interactive_uitest.cc
index 113bf284d78db97a046a19a11dbb61fc123a07fa..42e01b4b204623e42bc3c5373f26f117d6504fd5 100644
--- a/chrome/browser/password_manager/password_manager_interactive_uitest.cc
+++ b/chrome/browser/password_manager/password_manager_interactive_uitest.cc
@@ -81,7 +81,7 @@ IN_PROC_BROWSER_TEST_F(PasswordManagerBrowserTestBase, UsernameChanged) {
"document.getElementById('input_submit_button').click();";
ASSERT_TRUE(content::ExecuteScript(RenderViewHost(), submit));
navigation_observer.Wait();
- EXPECT_TRUE(prompt_observer.IsShowingSavePrompt());
+ EXPECT_TRUE(prompt_observer.IsSavePromptShownAutomatically());
prompt_observer.AcceptSavePrompt();
// Spin the message loop to make sure the password store had a chance to save
@@ -101,4 +101,24 @@ IN_PROC_BROWSER_TEST_F(PasswordManagerBrowserTestBase, UsernameChanged) {
(stored_passwords.begin()->second)[1].username_value);
}
+IN_PROC_BROWSER_TEST_F(PasswordManagerBrowserTestBase,
+ ManualFallbackForSaving) {
+ NavigateToFile("/password/password_form.html");
+
+ std::string focus("document.getElementById('password_field').focus();");
+ ASSERT_TRUE(content::ExecuteScript(RenderViewHost(), focus));
+ SimulateUserTypingInField(RenderViewHost(), WebContents(), "password_field");
+ BubbleObserver prompt_observer(WebContents());
+ prompt_observer.WaitForFallbackForSaving();
+
+ // The save prompt should be available but shouldn't pop up automatically.
+ EXPECT_TRUE(prompt_observer.IsSavePromptAvailable());
+ EXPECT_FALSE(prompt_observer.IsSavePromptShownAutomatically());
+
+ prompt_observer.AcceptSavePrompt();
+
+ WaitForPasswordStore();
+ CheckThatCredentialsStored(base::string16(), base::ASCIIToUTF16("ORARY"));
+}
+
} // namespace password_manager

Powered by Google App Engine
This is Rietveld 408576698