Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(49)

Unified Diff: chrome/browser/password_manager/chrome_password_manager_client.cc

Issue 2915763003: [Password Manager] Show omnibox icon and anchored prompt once user start typing password (Closed)
Patch Set: Rebase Created 3 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/password_manager/chrome_password_manager_client.cc
diff --git a/chrome/browser/password_manager/chrome_password_manager_client.cc b/chrome/browser/password_manager/chrome_password_manager_client.cc
index 4b7db57d63a4d06cedaf48b098e7beb879341035..540eee727e9aafd8737dfb7972b478141d30837c 100644
--- a/chrome/browser/password_manager/chrome_password_manager_client.cc
+++ b/chrome/browser/password_manager/chrome_password_manager_client.cc
@@ -296,6 +296,32 @@ bool ChromePasswordManagerClient::PromptUserToSaveOrUpdatePassword(
return true;
}
+void ChromePasswordManagerClient::ShowManualFallbackForSaving(
+ std::unique_ptr<password_manager::PasswordFormManager> form_to_save,
+ bool has_generated_password,
+ bool is_update) {
+ if (!CanShowBubbleOnURL(web_contents()->GetLastCommittedURL()))
+ return;
+
+#if !defined(OS_ANDROID)
+ PasswordsClientUIDelegate* manage_passwords_ui_controller =
+ PasswordsClientUIDelegateFromWebContents(web_contents());
+ manage_passwords_ui_controller->OnShowManualFallbackForSaving(
+ std::move(form_to_save), has_generated_password, is_update);
+#endif // !defined(OS_ANDROID)
+}
+
+void ChromePasswordManagerClient::HideManualFallbackForSaving() {
+ if (!CanShowBubbleOnURL(web_contents()->GetLastCommittedURL()))
+ return;
+
+#if !defined(OS_ANDROID)
+ PasswordsClientUIDelegate* manage_passwords_ui_controller =
+ PasswordsClientUIDelegateFromWebContents(web_contents());
+ manage_passwords_ui_controller->OnHideManualFallbackForSaving();
+#endif // !defined(OS_ANDROID)
+}
+
bool ChromePasswordManagerClient::PromptUserToChooseCredentials(
std::vector<std::unique_ptr<autofill::PasswordForm>> local_forms,
const GURL& origin,

Powered by Google App Engine
This is Rietveld 408576698