[Password Manager] Show omnibox icon and anchored prompt once user start typing password

chrome/browser/password_manager/password_manager_interactive_uitest.cc

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "base/strings/utf_string_conversions.h"
 #include "chrome/browser/password_manager/password_manager_test_base.h"
 #include "chrome/browser/password_manager/password_store_factory.h"
 #include "chrome/browser/ui/browser.h"
 #include "chrome/browser/ui/browser_commands.h"
 #include "components/password_manager/core/browser/test_password_store.h"
@@ skipping 63 matching lines @@
   // focus.
   chrome::FocusLocationBar(browser());
   WaitForElementValue("username_field", "tempORARY");
 
   NavigationObserver navigation_observer(WebContents());
   BubbleObserver prompt_observer(WebContents());
   std::string submit =
       "document.getElementById('input_submit_button').click();";
   ASSERT_TRUE(content::ExecuteScript(RenderViewHost(), submit));
   navigation_observer.Wait();
-  EXPECT_TRUE(prompt_observer.IsShowingSavePrompt());
+  EXPECT_TRUE(prompt_observer.WasSavePromptShown());
   prompt_observer.AcceptSavePrompt();
 
   // Spin the message loop to make sure the password store had a chance to save
   // the password.
   WaitForPasswordStore();
   EXPECT_FALSE(password_store->IsEmpty());
 
   // Verify that there are two saved password, the old password and the new
   // password.
   password_manager::TestPasswordStore::PasswordMap stored_passwords =
       password_store->stored_passwords();
   EXPECT_EQ(1u, stored_passwords.size());
   EXPECT_EQ(2u, stored_passwords.begin()->second.size());
   EXPECT_EQ(base::UTF8ToUTF16("temp"),
             (stored_passwords.begin()->second)[0].username_value);
   EXPECT_EQ(base::UTF8ToUTF16("tempORARY"),
             (stored_passwords.begin()->second)[1].username_value);
 }
 
+IN_PROC_BROWSER_TEST_F(PasswordManagerBrowserTestBase,
+                       ManualFallbackForSaving) {
+  NavigateToFile("/password/password_form.html");
+
+  std::string focus("document.getElementById('password_field').focus();");
+  ASSERT_TRUE(content::ExecuteScript(RenderViewHost(), focus));
+  SimulateUserTypingInField(RenderViewHost(), WebContents(), "password_field");
+  BubbleObserver prompt_observer(WebContents());
+  prompt_observer.WaitForSavePrompt();

[vasilii, 2017/08/03 10:46:37]

I think that is the only place which waits for the manual fallback and it's
confusing. There is no prompt in this test. We are waiting for the state. I'd
fix the name.

[kolos1, 2017/08/04 16:36:17]

Name is fixed. Special method for waiting for fallback is added.

+  EXPECT_TRUE(prompt_observer.IsSavePromptAvailable());
+  EXPECT_FALSE(prompt_observer.WasSavePromptShown());
+
+  prompt_observer.OpenAndAcceptSavePrompt();
+  WaitForPasswordStore();
+  scoped_refptr<password_manager::TestPasswordStore> password_store =
+      static_cast<password_manager::TestPasswordStore*>(
+          PasswordStoreFactory::GetForProfile(
+              browser()->profile(), ServiceAccessType::IMPLICIT_ACCESS)
+              .get());
+  CheckThatCredentialsStored(password_store.get(), base::string16(),

[vasilii, 2017/08/03 10:46:37]

One more example where we don't need |password_store| in the test.

[kolos1, 2017/08/04 16:36:17]

Acknowledged.

+                             base::ASCIIToUTF16("ORARY"));
+}
+
 }  // namespace password_manager