Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(208)

Side by Side Diff: chrome/browser/ui/passwords/manage_passwords_ui_controller.cc

Issue 2915763003: [Password Manager] Show omnibox icon and anchored prompt once user start typing password (Closed)
Patch Set: ui tests Created 3 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/ui/passwords/manage_passwords_ui_controller.h" 5 #include "chrome/browser/ui/passwords/manage_passwords_ui_controller.h"
6 6
7 #include <utility> 7 #include <utility>
8 8
9 #include "base/auto_reset.h" 9 #include "base/auto_reset.h"
10 #include "chrome/app/chrome_command_ids.h" 10 #include "chrome/app/chrome_command_ids.h"
(...skipping 76 matching lines...) Expand 10 before | Expand all | Expand 10 after
87 } 87 }
88 88
89 void ManagePasswordsUIController::OnUpdatePasswordSubmitted( 89 void ManagePasswordsUIController::OnUpdatePasswordSubmitted(
90 std::unique_ptr<PasswordFormManager> form_manager) { 90 std::unique_ptr<PasswordFormManager> form_manager) {
91 DestroyAccountChooser(); 91 DestroyAccountChooser();
92 passwords_data_.OnUpdatePassword(std::move(form_manager)); 92 passwords_data_.OnUpdatePassword(std::move(form_manager));
93 bubble_status_ = SHOULD_POP_UP; 93 bubble_status_ = SHOULD_POP_UP;
94 UpdateBubbleAndIconVisibility(); 94 UpdateBubbleAndIconVisibility();
95 } 95 }
96 96
97 void ManagePasswordsUIController::OnShowManualFallbackForSaving(
98 std::unique_ptr<PasswordFormManager> form_manager,
99 bool is_update) {
100 DestroyAccountChooser();
101 if (form_manager->has_generated_password())
vasilii 2017/08/02 17:41:11 Didn't we agree to drop it for now?
kolos1 2017/08/03 07:58:01 IIUC, the team agreed that we should show a confir
102 passwords_data_.OnAutomaticPasswordSave(std::move(form_manager));
103 else if (is_update)
104 passwords_data_.OnUpdatePassword(std::move(form_manager));
105 else
106 passwords_data_.OnPendingPassword(std::move(form_manager));
107 UpdateBubbleAndIconVisibility();
108 }
109
110 void ManagePasswordsUIController::OnHideManualFallbackForSaving() {
111 if (passwords_data_.state() != password_manager::ui::PENDING_PASSWORD_STATE &&
112 passwords_data_.state() !=
113 password_manager::ui::PENDING_PASSWORD_UPDATE_STATE &&
114 passwords_data_.state() != password_manager::ui::CONFIRMATION_STATE) {
115 return;
116 }
117
118 passwords_data_.TransitionToState(password_manager::ui::MANAGE_STATE);
119 UpdateBubbleAndIconVisibility();
120 }
121
97 bool ManagePasswordsUIController::OnChooseCredentials( 122 bool ManagePasswordsUIController::OnChooseCredentials(
98 std::vector<std::unique_ptr<autofill::PasswordForm>> local_credentials, 123 std::vector<std::unique_ptr<autofill::PasswordForm>> local_credentials,
99 const GURL& origin, 124 const GURL& origin,
100 const ManagePasswordsState::CredentialsCallback& callback) { 125 const ManagePasswordsState::CredentialsCallback& callback) {
101 DCHECK(!local_credentials.empty()); 126 DCHECK(!local_credentials.empty());
102 if (!HasBrowserWindow()) 127 if (!HasBrowserWindow())
103 return false; 128 return false;
104 // If |local_credentials| contains PSL matches they shouldn't be propagated to 129 // If |local_credentials| contains PSL matches they shouldn't be propagated to
105 // the state because PSL matches aren't saved for current page. This logic is 130 // the state because PSL matches aren't saved for current page. This logic is
106 // implemented here because Android uses ManagePasswordsState as a data source 131 // implemented here because Android uses ManagePasswordsState as a data source
(...skipping 372 matching lines...) Expand 10 before | Expand all | Expand 10 after
479 passwords_data_.TransitionToState(password_manager::ui::MANAGE_STATE); 504 passwords_data_.TransitionToState(password_manager::ui::MANAGE_STATE);
480 } 505 }
481 } 506 }
482 507
483 void ManagePasswordsUIController::WebContentsDestroyed() { 508 void ManagePasswordsUIController::WebContentsDestroyed() {
484 password_manager::PasswordStore* password_store = 509 password_manager::PasswordStore* password_store =
485 GetPasswordStore(web_contents()); 510 GetPasswordStore(web_contents());
486 if (password_store) 511 if (password_store)
487 password_store->RemoveObserver(this); 512 password_store->RemoveObserver(this);
488 } 513 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698