[Password Manager] Show omnibox icon and anchored prompt once user start typing password

chrome/browser/password_manager/password_manager_test_base.h

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_PASSWORD_MANAGER_PASSWORD_MANAGER_TEST_BASE_H_
 #define CHROME_BROWSER_PASSWORD_MANAGER_PASSWORD_MANAGER_TEST_BASE_H_
 
 #include <memory>
 
 #include "base/macros.h"
 #include "base/run_loop.h"
 #include "chrome/test/base/in_process_browser_test.h"
 #include "components/password_manager/core/browser/password_store_consumer.h"
 #include "content/public/browser/web_contents_observer.h"
 #include "net/cert/mock_cert_verifier.h"
 #include "net/test/embedded_test_server/embedded_test_server.h"
 
 namespace autofill {
 struct PasswordForm;
 }
+namespace password_manager {
+class TestPasswordStore;
+}
 
 class ManagePasswordsUIController;
 
 class NavigationObserver : public content::WebContentsObserver {
  public:
   explicit NavigationObserver(content::WebContents* web_contents);
   ~NavigationObserver() override;
 
   // Normally Wait() will not return until a main frame navigation occurs.
   // If a path is set, Wait() will return after this path has been seen,
@@ skipping 27 matching lines @@
   DISALLOW_COPY_AND_ASSIGN(NavigationObserver);
 };
 
 // Observes the save password prompt for a specified WebContents, keeps track of
 // whether or not it is currently shown, and allows accepting saving passwords
 // through it.
 class BubbleObserver {
  public:
   explicit BubbleObserver(content::WebContents* web_contents);
 
-  // Checks if the save prompt is being currently shown.
-  bool IsShowingSavePrompt() const;
+  // Checks if the save prompt is being currently available.
+  bool IsSavePromptAvailable() const;
 
-  // Checks if the update prompt is being currently shown.
-  bool IsShowingUpdatePrompt() const;
+  // Checks if the update prompt is being currently available.
+  bool IsUpdatePromptAvailable() const;
+
+  // Checks if the save prompt was shown.
+  bool WasSavePromptShown() const;
+
+  // Checks if the update prompt was shown.
+  bool WasUpdatePromptShown() const;
 
   // Dismisses the prompt currently open and moves the controller to the
   // inactive state.
   void Dismiss() const;
 
   // Expecting that the prompt is shown, saves the password. Checks that the
-  // prompt is no longer visible afterwards.
+  // prompt is no longer available.
   void AcceptSavePrompt() const;
 
+  // Expecting that the prompt is available, opens the prompt and saves the
+  // password. Checks that the prompt is no longer available.
+  void OpenAndAcceptSavePrompt() const;
+
   // Expecting that the prompt is shown, update |form| with the password from
   // observed form. Checks that the prompt is no longer visible afterwards.
   void AcceptUpdatePrompt(const autofill::PasswordForm& form) const;
 
   // Returns once the account chooser pops up or it's already shown.
   // |web_contents| must be the custom one returned by
   // PasswordManagerBrowserTestBase.
   void WaitForAccountChooser() const;
 
   // Returns once the UI controller is in the management state due to matching
@@ skipping 63 matching lines @@
   void CheckElementValue(const std::string& element_id,
                          const std::string& expected_value);
   // Same as above except the element |element_id| is in iframe |iframe_id|
   void CheckElementValue(const std::string& iframe_id,
                          const std::string& element_id,
                          const std::string& expected_value);
 
   // Synchronoulsy adds the given host to the list of valid HSTS hosts.
   void AddHSTSHost(const std::string& host);
 
+  // Checks that new credential is stored. For simplicity we assume that
+  // password store contains only 1 credential.

[vasilii, 2017/08/02 17:41:11]

I don't get from the comment if the method check that there is just one
credential or not.

[kolos1, 2017/08/03 07:58:01]

Changed the comment.

+  void CheckThatCredentialsStored(
+      password_manager::TestPasswordStore* password_store,

[vasilii, 2017/08/02 17:41:11]

What's the point to pass the store if it's essentially a singleton that it easy
to obtain?

[kolos1, 2017/08/03 07:58:01]

I just copied the function from
https://cs.chromium.org/chromium/src/chrome/browser/password_manager/password....


Yes, it can be obtained within the function, but the tests that use
CheckThatCredentialsStored already obtained the password store and use it for
additional checks. So, let them pass the store to the function. 

[vasilii, 2017/08/03 08:59:15]

It wasn't a method of a class.

[kolos1, 2017/08/03 09:08:03]

No, it wasn't. But in PasswordManagerBrowserTestBase we still have to call 
PasswordStoreFactory::GetForProfile
(https://cs.chromium.org/chromium/src/chrome/browser/password_manager/password...).
There is no direct pointer to the store or so, is there?

Is it not easier to pass the pointer to the store as an argument?

[vasilii, 2017/08/03 09:55:38]

From the point of view of the caller, obviously 2 arguments are better than 3.
Also I can easily imagine a test (e.g.
PasswordManagerBrowserTestBase.PromptForNormalSubmit) that doesn't need this
|store| pointer except for passing to the method. It hampers readabilty.

[kolos1, 2017/08/04 16:36:16]

Done.

+      const base::string16& username,
+      const base::string16& password);
+
   // Accessors
   // Return the first created tab with a custom ManagePasswordsUIController.
   content::WebContents* WebContents();
   content::RenderViewHost* RenderViewHost();
   content::RenderFrameHost* RenderFrameHost();
   net::EmbeddedTestServer& https_test_server() { return https_test_server_; }
   net::MockCertVerifier& mock_cert_verifier() { return mock_cert_verifier_; }
 
  private:
   net::EmbeddedTestServer https_test_server_;
   net::MockCertVerifier mock_cert_verifier_;
   // A tab with some hooks injected.
   content::WebContents* web_contents_;
   DISALLOW_COPY_AND_ASSIGN(PasswordManagerBrowserTestBase);
 };
 
 #endif  // CHROME_BROWSER_PASSWORD_MANAGER_PASSWORD_MANAGER_TEST_BASE_H_