Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(459)

Side by Side Diff: components/password_manager/core/browser/password_manager.h

Issue 2915763003: [Password Manager] Show omnibox icon and anchored prompt once user start typing password (Closed)
Patch Set: Sent For Review Created 3 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef COMPONENTS_PASSWORD_MANAGER_CORE_BROWSER_PASSWORD_MANAGER_H_ 5 #ifndef COMPONENTS_PASSWORD_MANAGER_CORE_BROWSER_PASSWORD_MANAGER_H_
6 #define COMPONENTS_PASSWORD_MANAGER_CORE_BROWSER_PASSWORD_MANAGER_H_ 6 #define COMPONENTS_PASSWORD_MANAGER_CORE_BROWSER_PASSWORD_MANAGER_H_
7 7
8 #include <map> 8 #include <map>
9 #include <memory> 9 #include <memory>
10 #include <string> 10 #include <string>
(...skipping 135 matching lines...) Expand 10 before | Expand all | Expand 10 after
146 // Handles a password form being submitted. 146 // Handles a password form being submitted.
147 virtual void OnPasswordFormSubmitted( 147 virtual void OnPasswordFormSubmitted(
148 password_manager::PasswordManagerDriver* driver, 148 password_manager::PasswordManagerDriver* driver,
149 const autofill::PasswordForm& password_form); 149 const autofill::PasswordForm& password_form);
150 150
151 // Handles a manual request to save password. 151 // Handles a manual request to save password.
152 void OnPasswordFormForceSaveRequested( 152 void OnPasswordFormForceSaveRequested(
153 password_manager::PasswordManagerDriver* driver, 153 password_manager::PasswordManagerDriver* driver,
154 const autofill::PasswordForm& password_form); 154 const autofill::PasswordForm& password_form);
155 155
156 // Handles a request to show manual fallback for password saving, i.e. the
157 // omnibox icon with the anchored hidden prompt.
158 void ShowManualFallback(password_manager::PasswordManagerDriver* driver,
vasilii 2017/07/21 12:48:20 ForSaving
kolos1 2017/07/24 15:33:30 Done.
159 const autofill::PasswordForm& password_form);
160
161 // Handles a request to hide manual fallback for password saving.
162 void HideManualFallback();
163
156 // Called if |password_form| was filled upon in-page navigation. This often 164 // Called if |password_form| was filled upon in-page navigation. This often
157 // means history.pushState being called from JavaScript. If this causes false 165 // means history.pushState being called from JavaScript. If this causes false
158 // positive in password saving, update http://crbug.com/357696. 166 // positive in password saving, update http://crbug.com/357696.
159 void OnInPageNavigation(password_manager::PasswordManagerDriver* driver, 167 void OnInPageNavigation(password_manager::PasswordManagerDriver* driver,
160 const autofill::PasswordForm& password_form); 168 const autofill::PasswordForm& password_form);
161 169
162 void ProcessAutofillPredictions( 170 void ProcessAutofillPredictions(
163 password_manager::PasswordManagerDriver* driver, 171 password_manager::PasswordManagerDriver* driver,
164 const std::vector<autofill::FormStructure*>& forms); 172 const std::vector<autofill::FormStructure*>& forms);
165 173
(...skipping 104 matching lines...) Expand 10 before | Expand all | Expand 10 after
270 278
271 // The user-visible URL from the last time a password was provisionally saved. 279 // The user-visible URL from the last time a password was provisionally saved.
272 GURL main_frame_url_; 280 GURL main_frame_url_;
273 281
274 DISALLOW_COPY_AND_ASSIGN(PasswordManager); 282 DISALLOW_COPY_AND_ASSIGN(PasswordManager);
275 }; 283 };
276 284
277 } // namespace password_manager 285 } // namespace password_manager
278 286
279 #endif // COMPONENTS_PASSWORD_MANAGER_CORE_BROWSER_PASSWORD_MANAGER_H_ 287 #endif // COMPONENTS_PASSWORD_MANAGER_CORE_BROWSER_PASSWORD_MANAGER_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698