Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(294)

Issue 2915673002: Relax a null check in context_manager.dart. (Closed)

Created:
3 years, 6 months ago by devoncarew
Modified:
3 years, 6 months ago
Reviewers:
Brian Wilkerson
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M pkg/analysis_server/lib/src/context_manager.dart View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5 (2 generated)
devoncarew
3 years, 6 months ago (2017-05-30 23:23:13 UTC) #2
Brian Wilkerson
lgtm, but we should see whether the test is failing because it hasn't been converted ...
3 years, 6 months ago (2017-05-30 23:55:50 UTC) #3
devoncarew
3 years, 6 months ago (2017-06-01 16:50:06 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
6c1625743c32bb0ec4630df7bd4183f2cc172f11 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698