Issue 2915643002: Fix IntelliJ debugging from returning scriptFailedToParse.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2915643002: Fix IntelliJ debugging from returning scriptFailedToParse. (Closed)

Created:
3 years, 6 months ago by terry

Modified:
3 years, 6 months ago

Reviewers:
Jacob

CC:
reviews+dom_dartlang.org, blink-reviews, blink-reviews-bindings_chromium.org

Target Ref:
refs/heads/releases/2661_work

Visibility:
Public.

Fix IntelliJ debugging from returning scriptFailedToParse. Part of Chromium 50 merge was a flipped sense because of an enum e.g., enum CompileResult { CompileSuccess, CompileError }; boolean is opposite sense success was 0 (CompileSuccess) and failure was 1 (CompileError). Now everything is consistent. BUG=29640 TBR=jacobr@google.com Committed: https://src.chromium.org/viewvc/chrome/branches/dart/dartium/src?view=rev&revision=67146b50bbc0dab33006c51b5dde056ee16f0f2b

Created: 3 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	third_party/WebKit/Source/bindings/core/dart/DartInspectorDebuggerAgent.cpp	View		1 chunk	+1 line, -1 line	0 comments	Download

Total messages: 3 (1 generated)

terry

Committed patchset #1 (id:1) manually as 67146b50bbc0dab33006c51b5dde056ee16f0f2b.

3 years, 6 months ago (2017-05-30 20:55:42 UTC) #2

Message was sent while issue was closed.

lgtm