Issue 291563008: make buildbot_globals.py read global_variables.json file from googlesource

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 291563008: make buildbot_globals.py read global_variables.json file from googlesource (Closed)

Created:
6 years, 7 months ago by epoger

Modified:
6 years, 7 months ago

Reviewers:
borenet

CC:
skia-review_googlegroups.com

Base URL:
https://skia.googlesource.com/skia.git@master

Visibility:
Public.

More Reviews

Description

make buildbot_globals.py read global_variables.json file from googlesource BUG=skia:2564 NOTRY=True Committed: http://code.google.com/p/skia/source/detail?r=14770

Patch Set 1 #

Total comments: 1

Created: 6 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+8 lines, -17 lines)			Patch
	M	tools/buildbot_globals.py	View		4 chunks	+8 lines, -17 lines	1 comment	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

epoger

Eric, PTAL https://codereview.chromium.org/291563008/diff/1/tools/buildbot_globals.py File tools/buildbot_globals.py (right): https://codereview.chromium.org/291563008/diff/1/tools/buildbot_globals.py#newcode1 tools/buildbot_globals.py:1: #!/usr/bin/python tested: $ tools/buildbot_globals.py android_master_host 108.170.220.21

6 years, 7 months ago (2014-05-16 18:37:42 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/epoger@google.com/291563008/1

6 years, 7 months ago (2014-05-16 19:19:26 UTC) #4

Message was sent while issue was closed.

Change committed as 14770

Expand Messages | Collapse Messages