Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1474)

Issue 291563004: Overload resolution: ignore extra arguments (Closed)

Created:
6 years, 7 months ago by Nils Barth (inactive)
Modified:
6 years, 7 months ago
Reviewers:
haraken, jsbell
CC:
blink-reviews, blink-reviews-bindings_chromium.org, arv+blink, abarth-chromium
Visibility:
Public.

Description

Overload resolution: ignore extra arguments 2.5 year old bug, now an easy fix. Implement this step of the algorithm: 2. Initialize argcount to be min(maxarg, n). This should be safe: it just allows looser calls (JS-style), and does not change any existing correct calls. R=haraken, jsbell BUG=102925 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=174181

Patch Set 1 #

Patch Set 2 : Rebaseline #

Unified diffs Side-by-side diffs Delta from patch set Stats (+81 lines, -84 lines) Patch
M LayoutTests/fast/canvas/canvas-overloads-drawImage-expected.txt View 1 2 chunks +4 lines, -4 lines 0 comments Download
M LayoutTests/fast/canvas/canvas-overloads-setFillColor-expected.txt View 1 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/canvas/canvas-overloads-setShadow-expected.txt View 1 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/canvas/canvas-overloads-setStrokeColor-expected.txt View 1 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/canvas/script-tests/canvas-overloads-drawImage.js View 1 2 chunks +4 lines, -4 lines 0 comments Download
M LayoutTests/fast/canvas/script-tests/canvas-overloads-setFillColor.js View 1 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/canvas/script-tests/canvas-overloads-setShadow.js View 1 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/canvas/script-tests/canvas-overloads-setStrokeColor.js View 1 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/js/resources/select-options-remove.js View 1 3 chunks +19 lines, -20 lines 0 comments Download
M LayoutTests/fast/js/select-options-remove-expected.txt View 1 2 chunks +17 lines, -17 lines 0 comments Download
M LayoutTests/vibration/vibration-exceptions.html View 1 1 chunk +3 lines, -3 lines 0 comments Download
M LayoutTests/vibration/vibration-exceptions-expected.txt View 1 1 chunk +3 lines, -3 lines 0 comments Download
M Source/bindings/templates/interface.cpp View 1 1 chunk +2 lines, -3 lines 0 comments Download
M Source/bindings/templates/methods.cpp View 1 1 chunk +2 lines, -3 lines 0 comments Download
M Source/bindings/tests/results/V8TestInterfaceConstructor.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M Source/bindings/tests/results/V8TestInterfaceConstructor2.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M Source/bindings/tests/results/V8TestObject.cpp View 1 19 chunks +19 lines, -19 lines 0 comments Download

Messages

Total messages: 13 (0 generated)
Nils Barth (inactive)
Now can quickly fix an old, old bug!
6 years, 7 months ago (2014-05-16 08:06:22 UTC) #1
haraken
LGTM.
6 years, 7 months ago (2014-05-16 08:19:47 UTC) #2
Nils Barth (inactive)
The CQ bit was checked by nbarth@chromium.org
6 years, 7 months ago (2014-05-16 08:22:45 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/nbarth@chromium.org/291563004/1
6 years, 7 months ago (2014-05-16 08:22:57 UTC) #4
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). Please consider checking whether the failures are ...
6 years, 7 months ago (2014-05-16 10:02:35 UTC) #5
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 7 months ago (2014-05-16 10:46:54 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: mac_blink_rel on tryserver.blink (http://build.chromium.org/p/tryserver.blink/builders/mac_blink_rel/builds/6858)
6 years, 7 months ago (2014-05-16 10:46:54 UTC) #7
Nils Barth (inactive)
The CQ bit was checked by nbarth@chromium.org
6 years, 7 months ago (2014-05-16 14:32:49 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/nbarth@chromium.org/291563004/20001
6 years, 7 months ago (2014-05-16 14:33:09 UTC) #9
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). Please consider checking whether the failures are ...
6 years, 7 months ago (2014-05-16 15:57:54 UTC) #10
commit-bot: I haz the power
Change committed as 174181
6 years, 7 months ago (2014-05-16 16:38:08 UTC) #11
jsbell
On 2014/05/16 16:38:08, I haz the power (commit-bot) wrote: > Change committed as 174181 Yay! ...
6 years, 7 months ago (2014-05-19 17:06:35 UTC) #12
Nils Barth (inactive)
6 years, 7 months ago (2014-05-26 03:14:42 UTC) #13
Message was sent while issue was closed.
On 2014/05/19 17:06:35, jsbell wrote:
> On 2014/05/16 16:38:08, I haz the power (commit-bot) wrote:
> > Change committed as 174181
> 
> Yay!
> 
> Thanks for including me on these patches, BTW. Due to {BlinkOn,Time
> Zones,haraken@ being super-fast} they usually land before I see them but I am
> skimming the patches.

No problem!
It's great to have actual *users* giving feedback and pain points!
BTW, Jens (jl@) is now actively working on bindings and esp. IDL support,
and is eager to help, so feel free to contact him with any requests or thoughts
(thanks Jens!).

Powered by Google App Engine
This is Rietveld 408576698