Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(361)

Issue 2915593004: update fasta StringToken.toString to make formatter happy (Closed)

Created:
3 years, 6 months ago by danrubel
Modified:
3 years, 6 months ago
Reviewers:
Paul Berry
CC:
reviews_dartlang.org, dart-fe-team+reviews_google.com
Target Ref:
refs/heads/master
Visibility:
Public.

Description

update fasta StringToken.toString to make formatter happy R=paulberry@google.com Committed: https://github.com/dart-lang/sdk/commit/f3a79c4e4ee6df37999363158e33d221360ed59f

Patch Set 1 #

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M pkg/front_end/lib/src/fasta/scanner/token.dart View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5 (2 generated)
danrubel
There's one spot in dartfmt that uses toString() rather than lexeme. There is a PR ...
3 years, 6 months ago (2017-05-30 20:10:30 UTC) #2
Paul Berry
lgtm
3 years, 6 months ago (2017-05-30 20:38:21 UTC) #3
danrubel
3 years, 6 months ago (2017-05-30 20:55:14 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
f3a79c4e4ee6df37999363158e33d221360ed59f (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698