Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(197)

Issue 291553005: Deprecate HTMLHeadElement.profile (Closed)

Created:
6 years, 7 months ago by philipj_slow
Modified:
6 years, 7 months ago
Reviewers:
ojan
CC:
blink-reviews, dglazkov+blink, blink-reviews-html_chromium.org, arv+blink, Inactive, watchdog-blink-watchlist_google.com
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -1 line) Patch
M LayoutTests/dom/html/level2/html/HTMLHeadElement01-expected.txt View 1 chunk +1 line, -0 lines 0 comments Download
M LayoutTests/dom/xhtml/level2/html/HTMLHeadElement01-expected.txt View 1 chunk +1 line, -0 lines 0 comments Download
M LayoutTests/fast/dom/element-attribute-js-null-expected.txt View 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/frame/UseCounter.cpp View 1 chunk +3 lines, -0 lines 0 comments Download
M Source/core/html/HTMLHeadElement.idl View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (0 generated)
philipj_slow
PTAL
6 years, 7 months ago (2014-05-23 09:13:28 UTC) #1
philipj_slow
Handing this over to Ojan. You said you wouldn't mind immediate removal on the list. ...
6 years, 7 months ago (2014-05-23 19:56:49 UTC) #2
ojan
lgtm It's certainly safer to deprecate and then remove later. I just wanted to save ...
6 years, 7 months ago (2014-05-23 20:00:28 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/philipj@opera.com/291553005/1
6 years, 7 months ago (2014-05-23 20:01:17 UTC) #4
philipj_slow
On 2014/05/23 20:00:28, ojan wrote: > lgtm > > It's certainly safer to deprecate and ...
6 years, 7 months ago (2014-05-23 20:03:09 UTC) #5
commit-bot: I haz the power
6 years, 7 months ago (2014-05-23 21:11:23 UTC) #6
Message was sent while issue was closed.
Change committed as 174710

Powered by Google App Engine
This is Rietveld 408576698