Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(29)

Unified Diff: extensions/browser/extension_throttle_manager.cc

Issue 2915523002: Replace deprecated base::NonThreadSafe in extensions in favor of SequenceChecker. (Closed)
Patch Set: Add TestBrowserThreadBundle Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « extensions/browser/extension_throttle_manager.h ('k') | extensions/browser/quota_service.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: extensions/browser/extension_throttle_manager.cc
diff --git a/extensions/browser/extension_throttle_manager.cc b/extensions/browser/extension_throttle_manager.cc
index c33d0207656fde29000231744f6ecf4a2cb2d517..bc3a810aae74d3923ad9e6b471b45ac1f9bf51e9 100644
--- a/extensions/browser/extension_throttle_manager.cc
+++ b/extensions/browser/extension_throttle_manager.cc
@@ -40,6 +40,7 @@ ExtensionThrottleManager::ExtensionThrottleManager()
}
ExtensionThrottleManager::~ExtensionThrottleManager() {
+ DCHECK_CALLED_ON_VALID_SEQUENCE(sequence_checker_);
net::NetworkChangeNotifier::RemoveIPAddressObserver(this);
net::NetworkChangeNotifier::RemoveConnectionTypeObserver(this);
@@ -69,7 +70,9 @@ ExtensionThrottleManager::MaybeCreateThrottle(const net::URLRequest* request) {
scoped_refptr<ExtensionThrottleEntryInterface>
ExtensionThrottleManager::RegisterRequestUrl(const GURL& url) {
- DCHECK(!enable_thread_checks_ || CalledOnValidThread());
+#if DCHECK_IS_ON()
+ DCHECK(!enable_thread_checks_ || sequence_checker_.CalledOnValidSequence());
+#endif // DCHECK_IS_ON()
// Normalize the url.
std::string url_id = GetIdFromUrl(url);
« no previous file with comments | « extensions/browser/extension_throttle_manager.h ('k') | extensions/browser/quota_service.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698