Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(370)

Unified Diff: extensions/browser/api/api_resource_manager.h

Issue 2915523002: Replace deprecated base::NonThreadSafe in extensions in favor of SequenceChecker. (Closed)
Patch Set: Add TestBrowserThreadBundle Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | extensions/browser/extension_throttle_manager.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: extensions/browser/api/api_resource_manager.h
diff --git a/extensions/browser/api/api_resource_manager.h b/extensions/browser/api/api_resource_manager.h
index 064e7454394c46aa21c37e79ac548c3b8b96faa2..8626e2182f3ae2f034215ccb5e0f6c62a2706769 100644
--- a/extensions/browser/api/api_resource_manager.h
+++ b/extensions/browser/api/api_resource_manager.h
@@ -14,7 +14,6 @@
#include "base/scoped_observer.h"
#include "base/sequence_checker.h"
#include "base/sequenced_task_runner.h"
-#include "base/threading/non_thread_safe.h"
#include "base/threading/sequenced_worker_pool.h"
#include "components/keyed_service/core/keyed_service.h"
#include "content/public/browser/browser_thread.h"
@@ -89,7 +88,6 @@ struct NamedThreadTraits {
// }
template <class T, typename ThreadingTraits = NamedThreadTraits<T>>
class ApiResourceManager : public BrowserContextKeyedAPI,
- public base::NonThreadSafe,
public ExtensionRegistryObserver,
public ProcessManagerObserver {
public:
@@ -102,7 +100,7 @@ class ApiResourceManager : public BrowserContextKeyedAPI,
}
virtual ~ApiResourceManager() {
- DCHECK(CalledOnValidThread());
+ DCHECK_CALLED_ON_VALID_SEQUENCE(sequence_checker_);
DCHECK(ThreadingTraits::IsMessageLoopValid())
<< "A unit test is using an ApiResourceManager but didn't provide "
"the thread message loop needed for that kind of resource. "
@@ -365,6 +363,8 @@ class ApiResourceManager : public BrowserContextKeyedAPI,
extension_registry_observer_;
ScopedObserver<ProcessManager, ProcessManagerObserver>
process_manager_observer_;
+
+ SEQUENCE_CHECKER(sequence_checker_);
};
template <class T>
« no previous file with comments | « no previous file | extensions/browser/extension_throttle_manager.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698