Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3)

Unified Diff: components/sync/base/weak_handle.h

Issue 2915453002: Deprecate NonThreadSafe in components/sync in favor of SequenceChecker. (Closed)
Patch Set: Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « components/sync/base/sync_prefs.cc ('k') | components/sync/device_info/local_device_info_provider_impl.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/sync/base/weak_handle.h
diff --git a/components/sync/base/weak_handle.h b/components/sync/base/weak_handle.h
index 5db9810c7b4fa5b4edcdf80c3fa163bfd2cf21a7..f496918e6c7f88050c355078f37edc12a99a2908 100644
--- a/components/sync/base/weak_handle.h
+++ b/components/sync/base/weak_handle.h
@@ -18,7 +18,8 @@
#include "base/memory/weak_ptr.h"
#include "base/single_thread_task_runner.h"
-// Weak handles provides a way to refer to weak pointers from another
+// SEQUENCE_CHECKER(sequence_checker_);
stanisc 2017/05/30 17:00:08 It looks like the script didn't handle this correc
gab 2017/05/31 17:42:23 Whoops..! Spent a lot of time to make the script h
+//// Weak handles provides a way to refer to weak pointers from another
// thread. This is useful because it is not safe to reference a weak
// pointer from a thread other than the thread on which it was
// created.
@@ -47,7 +48,7 @@
// const WeakHandle<Foo> foo_;
// };
//
-// class Foo : public SupportsWeakPtr<Foo>, public NonThreadSafe {
+// class Foo : public SupportsWeakPtr<Foo> {
// public:
// Foo() {
// SpawnFooIOWorkerOnIOThread(base::MakeWeakHandle(AsWeakPtr()));
« no previous file with comments | « components/sync/base/sync_prefs.cc ('k') | components/sync/device_info/local_device_info_provider_impl.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698