Issue 2915343002: Revert "Only call MirrorsData.retainMetadata* from codegen"

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2915343002: Revert "Only call MirrorsData.retainMetadata* from codegen" (Closed)

Created:
3 years, 6 months ago by Johnni Winther

Modified:
3 years, 6 months ago

Reviewers:
Siggi Cherem (dart-lang)

CC:
reviews_dartlang.org

Target Ref:
refs/heads/master

Visibility:
Public.

Revert "Only call MirrorsData.retainMetadata* from codegen" This reverts commit 7b9875cd8cf26910e1779ea101af0bcd8705bed4. Committed: https://github.com/dart-lang/sdk/commit/3e876bb0107db02bf81805a0c87ac1fe0dc8ebd6

Created: 3 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+39 lines, -21 lines)			Patch
	M	pkg/compiler/lib/src/js_backend/mirrors_analysis.dart	View		2 chunks	+28 lines, -14 lines	0 comments	Download
	M	pkg/compiler/lib/src/js_backend/mirrors_data.dart	View		2 chunks	+11 lines, -7 lines	0 comments	Download

Total messages: 4 (2 generated)

Johnni Winther

3 years, 6 months ago (2017-06-02 20:07:15 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
3e876bb0107db02bf81805a0c87ac1fe0dc8ebd6 (presubmit successful).