Wiring Libjingle network related metrics into Chrome

tools/metrics/histograms/histograms.xml

Index: tools/metrics/histograms/histograms.xml
diff --git a/tools/metrics/histograms/histograms.xml b/tools/metrics/histograms/histograms.xml
index 4290a7dd94dfdf04232fff6e81168c520bc7a7ce..5c31afe6e8486324a8f64b3b14a7c9a41eb110ac 100644
--- a/tools/metrics/histograms/histograms.xml
+++ b/tools/metrics/histograms/histograms.xml
@@ -31167,6 +31167,33 @@ Therefore, the affected-histogram name has to have at least one dot in it.
   </summary>
 </histogram>
 
+<histogram name="WebRTC.PeerConnectionIPMetrics" enum="PeerConnectionCounters">

[Alexei Svitkine (slow), 2014/05/22 08:35:35]

Nit: I suggest to rename these histograms to WebRTC.PeerConnection.IPMetrics,
WebRTC.PeerConnection.TimeToConnect and so forth. This will let you bring up all
the related metrics easily on the UMA dashboard.

[Mallinath (Gone from Chromium), 2014/05/22 15:46:36]

That's good point.
On 2014/05/22 08:35:35, Alexei Svitkine wrote:

+  <owner>mallinath@chromium.org</owner>
+  <summary>
+    Counters on IPv4 and IPv6 usage in PeerConnection. These values logged once

[perkj_chrome, 2014/05/22 07:38:58]

values are logged

[Mallinath (Gone from Chromium), 2014/05/22 15:46:36]

Done.

+    per PeerConnection.
+  </summary>
+</histogram>
+
+<histogram name="WebRTC.PeerConnectionIPv4Interfaces">
+  <owner>mallinath@chromium.org</owner>
+  <summary>
+    Number of IPv4 network interfaces discovered in a PeerConnection Session.
+  </summary>
+</histogram>
+
+<histogram name="WebRTC.PeerConnectionIPv6Interfaces">
+  <owner>mallinath@chromium.org</owner>
+  <summary>
+    Number of IPv6 network interfaces discovered in a PeerConnection Session.
+  </summary>
+</histogram>
+
+<histogram name="WebRTC.PeerConnectionTimeToConnect" units="milliseconds">
+  <owner>mallinath@chromium.org</owner>
+  <summary>Time to setup a peer to peer call with PeerConnection.</summary>
+</histogram>
+
 <histogram name="WebRTC.ReceivedAudioTrackDuration" units="milliseconds">
   <owner>perkj@chromium.org</owner>
   <summary>
@@ -39847,6 +39874,13 @@ Therefore, the affected-histogram name has to have at least one dot in it.
   <int value="6" label="Clicked 'Enable password manager'"/>
 </enum>
 
+<enum name="PeerConnectionCounters" type="int">

[perkj_chrome, 2014/05/22 07:38:58]

Should this be moved to just after <histogram
name="WebRTC.PeerConnectionIPMetrics" enum="PeerConnectionCounters">
+  <owner>mallinath@chromium.org</owner> ? 

[Alexei Svitkine (slow), 2014/05/22 08:35:35]

The ordering of entries in this file is enforced by the presubmits.

+  <int value="0" label="PeerConnection enabled with IPv4."/>
+  <int value="1" label="PeerConnection enabled with Ipv6."/>

[perkj_chrome, 2014/05/22 07:38:58]

What is the difference between these values? IPv4 BestConnection and
PeerConnection enabled with IPv4 ? Can one session have both IPV4 and IpV6
enabled but only one best connection?

[Mallinath (Gone from Chromium), 2014/05/22 15:46:36]

Yes, that's what will happen. When IPv6 is enabled, IPv4 will also be enabled.
So we want to know, in how many cases we had Ipv4 best connection and visa
versa.
On 2014/05/22 07:38:58, perkj wrote:

+  <int value="2" label="IPv4 BestConnection."/>
+  <int value="3" label="IPv6 BestConnection."/>
+</enum>
+
 <enum name="PepperInterface" type="int">
 <!-- Generated by ppapi/tools/pepper_hash_for_uma.cc -->