Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(549)

Issue 29153007: IDL compiler: [CallWith] for setters (Closed)

Created:
7 years, 2 months ago by Nils Barth (inactive)
Modified:
7 years, 2 months ago
Reviewers:
haraken
CC:
blink-reviews, kojih, jsbell+bindings_chromium.org, abarth-chromium, marja+watch_chromium.org, adamk+blink_chromium.org, Nate Chapin, Inactive, kouhei (in TOK)
Visibility:
Public.

Description

IDL compiler: [CallWith] for setters Simple one, main change is now we need a function for the setter_expression, analogous to the one for getter_expression. (We'll add more cases to this in future.) Docs: https://sites.google.com/a/chromium.org/dev/blink/webidl/blink-idl-extended-attributes#TOC-CallWith-m-a- BUG=239771 NOTRY=true Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=160000

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+34 lines, -11 lines) Patch
M Source/bindings/scripts/unstable/v8_attributes.py View 2 chunks +10 lines, -5 lines 0 comments Download
M Source/bindings/templates/attributes.cpp View 1 chunk +3 lines, -0 lines 0 comments Download
M Source/bindings/tests/idls/TestObjectPython.idl View 1 chunk +1 line, -1 line 0 comments Download
M Source/bindings/tests/results/V8TestObjectPython.cpp View 2 chunks +20 lines, -5 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
Nils Barth (inactive)
Quick one.
7 years, 2 months ago (2013-10-19 03:18:30 UTC) #1
haraken
LGTM
7 years, 2 months ago (2013-10-19 04:40:48 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/nbarth@chromium.org/29153007/1
7 years, 2 months ago (2013-10-19 04:45:47 UTC) #3
commit-bot: I haz the power
Change committed as 160000
7 years, 2 months ago (2013-10-19 10:38:35 UTC) #4
Nils Barth (inactive)
On 2013/10/19 10:38:35, I haz the power (commit-bot) wrote: > Change committed as 160000 Nice ...
7 years, 2 months ago (2013-10-19 10:44:26 UTC) #5
haraken
On 2013/10/19 10:44:26, Nils Barth wrote: > On 2013/10/19 10:38:35, I haz the power (commit-bot) ...
7 years, 2 months ago (2013-10-19 10:51:17 UTC) #6
Nils Barth (inactive)
On 2013/10/19 10:51:17, haraken wrote: > On 2013/10/19 10:44:26, Nils Barth wrote: > > On ...
7 years, 2 months ago (2013-10-19 11:04:40 UTC) #7
haraken
> A Mersenne prime would be nice; last one was 131071 (1 year ago), next ...
7 years, 2 months ago (2013-10-19 11:14:01 UTC) #8
Nils Barth (inactive)
7 years, 2 months ago (2013-10-19 11:15:07 UTC) #9
Message was sent while issue was closed.
On 2013/10/19 11:14:01, haraken wrote:
> > A Mersenne prime would be nice; last one was 131071 (1 year ago), next one
is
> > 524287,
> > which will probably take quite a while.
> 
> Sounds nice. But let's finish the IDL compiler rewrite before then :)

I don't think it'll take *quite* that many CLs ;)

Powered by Google App Engine
This is Rietveld 408576698